public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: v3.7: Unloading ib_ipoib triggers circular locking dependency complaint
Date: Wed, 13 Mar 2013 17:43:09 +0200	[thread overview]
Message-ID: <51409E8D.7030304@mellanox.com> (raw)
In-Reply-To: <513F3455.3030309-HInyCGIudOg@public.gmane.org>

On 12/03/2013 15:57, Bart Van Assche wrote:
> On 11/26/12 09:00, Or Gerlitz wrote:
>> On Fri, Nov 23, 2012 at 2:10 PM, Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org> 
>> wrote:
>>> Apparently unloading the ib_ipoib kernel module triggers a circular 
>>> locking
>>> dependency complaint. Has anyone already been looking into this ?
>>
>> Yes, I see that this happens here e.g when doing hot-unplug to the
>> underlying HW driver, seems related to the ipoib rtnl ops patches I
>> pushed to 3.7 -- will look into this, thanks for bringing this up.
>> Does anyone has an idea where the "s_active" lock is defined and what
>> is its role?
>
> (replying to an e-mail from a few months ago) I still see this with 
> kernel 3.8.0. This warning probably means that sysfs_remove_dir() is 
> invoked with the rtnl lock held. If so I think that this can trigger a 
> deadlock during module removal.

Yep, something goes wrong w.r.t to the interaction with sysfs and rtnl, 
at some point very similar lockdep traces were sent to netdev from other 
drivers and a generic solution was suggested, but I am not sure where 
this has landed, see

http://marc.info/?l=linux-kernel&m=135293378513907&w=2
http://marc.info/?l=linux-netdev&m=135438302622434&w=2

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2013-03-13 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-23 12:10 v3.7: Unloading ib_ipoib triggers circular locking dependency complaint Bart Van Assche
     [not found] ` <50AF67C5.7090200-HInyCGIudOg@public.gmane.org>
2012-11-26  8:00   ` Or Gerlitz
     [not found]     ` <CAJZOPZJ55dqpOsnP-jbgXRrLZpyRzD2v8pg7pAAWMtWWr-m1FA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-26 10:08       ` Roland Dreier
2013-03-12 13:57       ` Bart Van Assche
     [not found]         ` <513F3455.3030309-HInyCGIudOg@public.gmane.org>
2013-03-13 15:43           ` Or Gerlitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51409E8D.7030304@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=bvanassche-HInyCGIudOg@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox