Re: [Fwd: Re: [PATCH] libibmad: Fixes for failures when not all ports of HCA are connected]

[brendan doyle <brendan.doyle-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On 21/03/2013 22:53, Weiny, Ira wrote:
>> -----Original Message-----
>> From: Jason Gunthorpe [mailto:jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org]
>> Sent: Thursday, March 21, 2013 3:50 PM
>> To: Weiny, Ira
>> Cc: brendan doyle; Boris Chiu; iweiny-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; linux-
>> rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Pramod Gunjikar
>> Subject: Re: [Fwd: Re: [PATCH] libibmad: Fixes for failures when not all ports
>> of HCA are connected]
>>
>> On Thu, Mar 21, 2013 at 10:46:06PM +0000, Weiny, Ira wrote:
>>
>>> have to follow different idioms.  However having 2 or 3 in the same
>>> library is even worse!!!
>> Agreed, I think you made a compelling case that the new POSIX method is
>> not appropriate for this library, so standardizing on the old method is the
>> least bad option..
>>
> Wait what did I do?
>
> You think using errno is the "right" thing to do now?

I agree that it is the least bad option, I don't want to fix the int 
return APIs, as I
think that will break infiniband-diags and who knows what else, and as 
you say we
then end up with two or 3 idioms within the same library. I think it's 
too much of
a stretch, at least for me to go redo the whole lib, so the best we can 
do is at least
be consistent.

I'm going to be traveling shortly I'll take another look at the patch 
next week.


>
> Ira
>
>> So Brandon, maybe redo your patch do get rid of the bogus errno != 0 stuff?
>>
>> Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html