From mboxrd@z Thu Jan 1 00:00:00 1970 From: brendan doyle Subject: Re: [Fwd: Re: [PATCH] libibmad: Fixes for failures when not all ports of HCA are connected] Date: Thu, 21 Mar 2013 23:04:53 +0000 Message-ID: <514B9215.2000106@oracle.com> References: <20130320222422.GA30100@obsidianresearch.com> <514A3BDF.2090105@oracle.com> <20130320231923.GA32300@obsidianresearch.com> <514A5C07.3080308@oracle.com> <20130321052122.GB20882@obsidianresearch.com> <514B6F74.9020707@oracle.com> <20130321212703.GA8431@obsidianresearch.com> <2807E5FD2F6FDA4886F6618EAC48510EBB4AF5@CRSMSX102.amr.corp.intel.com> <20130321220751.GG8431@obsidianresearch.com> <2807E5FD2F6FDA4886F6618EAC48510EBB4B49@CRSMSX102.amr.corp.intel.com> <20130321225018.GA9749@obsidianresearch.com> <2807E5FD2F6FDA4886F6618EAC48510EBB4B7E@CRSMSX102.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510EBB4B7E-8k97q/ur5Z1cIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Weiny, Ira" Cc: Jason Gunthorpe , Boris Chiu , "iweiny-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Pramod Gunjikar List-Id: linux-rdma@vger.kernel.org On 21/03/2013 22:53, Weiny, Ira wrote: >> -----Original Message----- >> From: Jason Gunthorpe [mailto:jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org] >> Sent: Thursday, March 21, 2013 3:50 PM >> To: Weiny, Ira >> Cc: brendan doyle; Boris Chiu; iweiny-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; linux- >> rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Pramod Gunjikar >> Subject: Re: [Fwd: Re: [PATCH] libibmad: Fixes for failures when not all ports >> of HCA are connected] >> >> On Thu, Mar 21, 2013 at 10:46:06PM +0000, Weiny, Ira wrote: >> >>> have to follow different idioms. However having 2 or 3 in the same >>> library is even worse!!! >> Agreed, I think you made a compelling case that the new POSIX method is >> not appropriate for this library, so standardizing on the old method is the >> least bad option.. >> > Wait what did I do? > > You think using errno is the "right" thing to do now? I agree that it is the least bad option, I don't want to fix the int return APIs, as I think that will break infiniband-diags and who knows what else, and as you say we then end up with two or 3 idioms within the same library. I think it's too much of a stretch, at least for me to go redo the whole lib, so the best we can do is at least be consistent. I'm going to be traveling shortly I'll take another look at the patch next week. > > Ira > >> So Brandon, maybe redo your patch do get rid of the bogus errno != 0 stuff? >> >> Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html