From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] opensm: Add missing newline to end of log message
Date: Wed, 27 Mar 2013 08:43:24 -0400 [thread overview]
Message-ID: <5152E96C.6090002@dev.mellanox.co.il> (raw)
In-Reply-To: <1364321798.878.19.camel-akkeaxHeDKRliZ7u+bvwcg@public.gmane.org>
On 3/26/2013 2:16 PM, Albert Chu wrote:
> Signed-off-by: Albert L. Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> ---
> opensm/osm_helper.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/opensm/osm_helper.c b/opensm/osm_helper.c
> index 219554a..95462a7 100644
> --- a/opensm/osm_helper.c
> +++ b/opensm/osm_helper.c
> @@ -2848,6 +2848,7 @@ static void osm_dump_smp_dr_path_to_buf(IN const ib_smp_t * p_smp,
> n += snprintf(buf + n, buf_size - n, ", Return path = ");
> n += sprint_uint8_arr(buf + n, buf_size - n,
> p_smp->return_path, p_smp->hop_count + 1);
> + n += sprintf(buf + n, "\n");
I'm missing why that's needed. Isn't it currently taken care of by the
callers to this routine ?
-- Hal
> }
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-03-27 12:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 18:16 [PATCH] opensm: Add missing newline to end of log message Albert Chu
[not found] ` <1364321798.878.19.camel-akkeaxHeDKRliZ7u+bvwcg@public.gmane.org>
2013-03-27 12:43 ` Hal Rosenstock [this message]
[not found] ` <5152E96C.6090002-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-03-27 16:49 ` Albert Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5152E96C.6090002@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=chu11-i2BcT+NCU+M@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox