[PATCH] opensm: Add missing newline to end of log message

[PATCH] opensm: Add missing newline to end of log message

[Albert Chu]

Signed-off-by: Albert L. Chu <chu11-i2BcT+NCU+M@public.gmane.org>
---
 opensm/osm_helper.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/opensm/osm_helper.c b/opensm/osm_helper.c
index 219554a..95462a7 100644
--- a/opensm/osm_helper.c
+++ b/opensm/osm_helper.c
@@ -2848,6 +2848,7 @@ static void osm_dump_smp_dr_path_to_buf(IN const ib_smp_t * p_smp,
 		n += snprintf(buf + n, buf_size - n, ", Return path  = ");
 		n += sprint_uint8_arr(buf + n, buf_size - n,
 				      p_smp->return_path, p_smp->hop_count + 1);
+		n += sprintf(buf + n, "\n");
 	}
 }
 
-- 
1.7.1



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm: Add missing newline to end of log message

[Hal Rosenstock]

On 3/26/2013 2:16 PM, Albert Chu wrote:
> Signed-off-by: Albert L. Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> ---
>  opensm/osm_helper.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/opensm/osm_helper.c b/opensm/osm_helper.c
> index 219554a..95462a7 100644
> --- a/opensm/osm_helper.c
> +++ b/opensm/osm_helper.c
> @@ -2848,6 +2848,7 @@ static void osm_dump_smp_dr_path_to_buf(IN const ib_smp_t * p_smp,
>  		n += snprintf(buf + n, buf_size - n, ", Return path  = ");
>  		n += sprint_uint8_arr(buf + n, buf_size - n,
>  				      p_smp->return_path, p_smp->hop_count + 1);
> +		n += sprintf(buf + n, "\n");

I'm missing why that's needed. Isn't it currently taken care of by the
callers to this routine ?

-- Hal

>  	}
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm: Add missing newline to end of log message

[Albert Chu]

On Wed, 2013-03-27 at 08:43 -0400, Hal Rosenstock wrote:
> On 3/26/2013 2:16 PM, Albert Chu wrote:
> > Signed-off-by: Albert L. Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> > ---
> >  opensm/osm_helper.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/opensm/osm_helper.c b/opensm/osm_helper.c
> > index 219554a..95462a7 100644
> > --- a/opensm/osm_helper.c
> > +++ b/opensm/osm_helper.c
> > @@ -2848,6 +2848,7 @@ static void osm_dump_smp_dr_path_to_buf(IN const ib_smp_t * p_smp,
> >  		n += snprintf(buf + n, buf_size - n, ", Return path  = ");
> >  		n += sprint_uint8_arr(buf + n, buf_size - n,
> >  				      p_smp->return_path, p_smp->hop_count + 1);
> > +		n += sprintf(buf + n, "\n");
> 
> I'm missing why that's needed. Isn't it currently taken care of by the
> callers to this routine ?

Sorry, I missed that this had been fixed upstream via your commit on
10-03-2012 (dba3f9289d4277f67474e75cfe5979a6cc74487c).   Our local tree
is just out of date.

Al

> -- Hal
> 
> >  	}
> >  }
> >  
> 
-- 
Albert Chu
chu11-i2BcT+NCU+M@public.gmane.org
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html