From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH] IB/mlx4: Fail post send command on error recovery Date: Tue, 2 Apr 2013 12:15:50 +0300 Message-ID: <515AA1C6.7070804@mellanox.com> References: <1364496315-7588-1-git-send-email-klebers@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1364496315-7588-1-git-send-email-klebers-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kleber Sacilotto de Souza Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Roland Dreier , Sean Hefty , Hal Rosenstock , Jack Morgenstein List-Id: linux-rdma@vger.kernel.org On 28/03/2013 20:45, Kleber Sacilotto de Souza wrote: > When the PCI adapter is going through error recovery, a call to > mlx4_ib_post_send() will return success without the command actually > arriving to the hardware. Adding a call to pci_channel_offline() to > check the state of the PCI slot and returning an error will allow the > upper layers to be aware that the command didn't succeed. Is putting this call in fast path common practice in other (e.g Ethernet) drivers? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html