public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH libibverbs 1/3] Add raw packet QP type
Date: Thu, 4 Apr 2013 08:58:23 +0300	[thread overview]
Message-ID: <515D167F.9070701@mellanox.com> (raw)
In-Reply-To: <1348173034-11929-2-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

On 20/09/2012 22:30, Or Gerlitz wrote:
> IB_QPT_RAW_PACKET allows applications to build a complete packet,
> including L2 headers, when sending; on the receive side, the HW will
> not strip any headers.

Hi Roland,

I happily saw that you've finally picked the libmlx4 patches to support 
RAW QP, so we're making progress... any reason not to pick this series?

Or.

>
> This QP type is designed for userspace direct access to Ethernet; for
> example by applications that do TCP/IP themselves.  Only processes
> with the NET_RAW capability are allowed to create raw packet QPs (the
> name "raw packet QP" is supposed to suggest an analogy to AF_PACKET /
> SOL_RAW sockets).
>
> Signed-off-by: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>   include/infiniband/verbs.h |    3 ++-
>   man/ibv_create_qp.3        |    2 +-
>   man/ibv_modify_qp.3        |   10 ++++++++++
>   3 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h
> index 6acfc81..8ed8a66 100644
> --- a/include/infiniband/verbs.h
> +++ b/include/infiniband/verbs.h
> @@ -399,7 +399,8 @@ struct ibv_srq_init_attr {
>   enum ibv_qp_type {
>   	IBV_QPT_RC = 2,
>   	IBV_QPT_UC,
> -	IBV_QPT_UD
> +	IBV_QPT_UD,
> +	IBV_QPT_RAW_PACKET = 8
>   };
>   
>   struct ibv_qp_cap {
> diff --git a/man/ibv_create_qp.3 b/man/ibv_create_qp.3
> index 5301ad8..7feeab2 100644
> --- a/man/ibv_create_qp.3
> +++ b/man/ibv_create_qp.3
> @@ -28,7 +28,7 @@ struct ibv_cq          *send_cq;        /* CQ to be associated with the Send Que
>   struct ibv_cq          *recv_cq;        /* CQ to be associated with the Receive Queue (RQ) */
>   struct ibv_srq         *srq;            /* SRQ handle if QP is to be associated with an SRQ, otherwise NULL */
>   struct ibv_qp_cap       cap;            /* QP capabilities */
> -enum ibv_qp_type        qp_type;        /* QP Transport Service Type: IBV_QPT_RC, IBV_QPT_UC, or IBV_QPT_UD */
> +enum ibv_qp_type        qp_type;        /* QP Transport Service Type: IBV_QPT_RC, IBV_QPT_UC, IBV_QPT_UD or IBV_QPT_RAW_PACKET */
>   int                     sq_sig_all;     /* If set, each Work Request (WR) submitted to the SQ generates a completion entry */
>   .in -8
>   };
> diff --git a/man/ibv_modify_qp.3 b/man/ibv_modify_qp.3
> index 9eabcdf..cb3faaa 100644
> --- a/man/ibv_modify_qp.3
> +++ b/man/ibv_modify_qp.3
> @@ -159,6 +159,16 @@ RTR  \fB          IBV_QP_STATE, IBV_QP_AV, IBV_QP_PATH_MTU, \fR
>   RTS  \fB          IBV_QP_STATE, IBV_QP_SQ_PSN, IBV_QP_MAX_QP_RD_ATOMIC, \fR
>        \fB          IBV_QP_RETRY_CNT, IBV_QP_RNR_RETRY, IBV_QP_TIMEOUT \fR
>   .fi
> +.PP
> +.nf
> +For QP Transport Service Type \fB IBV_QPT_RAW_PACKET\fR:
> +.sp
> +Next state     Required attributes
> +\-\-\-\-\-\-\-\-\-\-     \-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-
> +Init \fB          IBV_QP_STATE, IBV_QP_PORT\fR
> +RTR  \fB          IBV_QP_STATE\fR
> +RTS  \fB          IBV_QP_STATE\fR
> +.fi
>   .SH "SEE ALSO"
>   .BR ibv_create_qp (3),
>   .BR ibv_destroy_qp (3),

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-04-04  5:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20 20:30 [PATCH libibverbs 0/3] add raw packet QP, new helper and examples cleanups Or Gerlitz
     [not found] ` <1348173034-11929-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-09-20 20:30   ` [PATCH libibverbs 1/3] Add raw packet QP type Or Gerlitz
     [not found]     ` <1348173034-11929-2-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-04-04  5:58       ` Or Gerlitz [this message]
2012-09-20 20:30   ` [PATCH libibverbs 2/3] Add helpers to deal with new InfiniBand link speeds Or Gerlitz
2012-09-20 20:30   ` [PATCH libibverbs 3/3] Fix resource leaks in the pingpong examples present in the failure/error flows Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515D167F.9070701@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox