Re: [ANNOUNCE] SRP: ProfitBricks publishes its SRP Initiator patches

[Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>]

On 05/06/13 10:44, Sebastian Riemer wrote:
> Sorry Bart, but a reconnect with just the commit message
> "IB/srp: Add kernel-level transport layer recovery" and no further
> description isn't very trustworthy for me. I also wonder why you need so
> much locking.

Hello Sebastian,

There is a very good reason for all that locking: during device removal 
the rport structure is freed before SCSI host removal finished. So when 
converting a SCSI host pointer into an rport pointer protection is 
needed against device removal. The current approach in the 
ib_srp-backport repository is to realize that protection via locking. 
I'm currently reworking that approach into protection via reference 
counting such that it is guaranteed that the rport remains to exist 
until scsi_remove_device() has finished. That will allow to eliminate 
several locking statements.

Sorry for the terse patch descriptions - I had not expected that anyone 
would try to understand the patches ib_srp-backport repository and use 
these as a basis for further work.

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html