public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Tom Tucker <tom-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: MLX4 Cq Question
Date: Fri, 17 May 2013 14:25:44 -0500	[thread overview]
Message-ID: <51968438.7070907@opengridcomputing.com> (raw)

Hi Roland,

I'm looking at the Linux MLX4 net driver and found something that confuses 
me mightily. In particular in the file net/ethernet/mellanox/mlx4/cq.c, 
the mlx4_ib_completion function does not take any kind of lock when 
looking up the SW CQ in the radix tree, however, the mlx4_cq_event 
function does. In addition if I go look at the code paths where cq are 
removed from this tree, they are protected by spin_lock_irq. So I am 
baffled at this point as to what the locking strategy is and how this is 
supposed to work. I'm sure I'm missing something and would greatly 
appreciate it if someone would explain this.

Thanks,
Tom

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2013-05-17 19:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 19:25 Tom Tucker [this message]
     [not found] ` <51968438.7070907-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2013-05-17 21:37   ` MLX4 Cq Question Roland Dreier
     [not found]     ` <CAG4TOxNi0PxxskqXgxRhMPG0bmr+sS-x0_RG-zKyvLW1LNzoBg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-19  6:09       ` Or Gerlitz
2013-05-20 14:53       ` Jack Morgenstein
     [not found]         ` <201305201753.10806.jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-05-20 16:07           ` Roland Dreier
2013-05-20 19:51           ` Tom Tucker
     [not found]             ` <519A7EB2.8090206-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2013-05-20 19:58               ` Hefty, Sean
     [not found]                 ` <1828884A29C6694DAF28B7E6B8A823736FD2955D-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-05-20 20:10                   ` Tom Tucker
2013-05-20 20:11                   ` Or Gerlitz
2013-05-21  9:40           ` Or Gerlitz
     [not found]             ` <519B4104.4090102-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-05-21 10:42               ` Bart Van Assche
     [not found]                 ` <519B4F81.9040108-HInyCGIudOg@public.gmane.org>
2013-05-21 10:43                   ` Or Gerlitz
     [not found]                     ` <519B4FEB.5090701-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-05-21 14:13                       ` Jack Morgenstein
     [not found]                         ` <201305211713.24370.jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-05-21 15:10                           ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51968438.7070907@opengridcomputing.com \
    --to=tom-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox