From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hal Rosenstock Subject: Re: [PATCH v3] Add trap details to notice log message Date: Fri, 31 May 2013 12:46:26 -0400 Message-ID: <51A8D3E2.2010104@dev.mellanox.co.il> References: <1828884A29C6694DAF28B7E6B8A823736FD2C024@ORSMSX109.amr.corp.intel.com> <51A85DE4.2000506@oracle.com> <1828884A29C6694DAF28B7E6B8A823736FD2C27A@ORSMSX109.amr.corp.intel.com> <51A8C527.5070306@dev.mellanox.co.il> <51A8D35D.7010203@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51A8D35D.7010203-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Line Holen Cc: "Hefty, Sean" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 5/31/2013 12:44 PM, Line Holen wrote: > On 05/31/13 17:43, Hal Rosenstock wrote: >> On 5/31/2013 10:40 AM, Hefty, Sean wrote: >>>> Are you suggesting to do this in addition to ib_types.h or instead of ? >>>> umad_sm.h seems to hold only a small subset of what's found in >>>> ib_types.h. >>> umad_sm.h was only recently added. >> and there is no release yet with those files. >> >>> I'm suggesting to put the definitions there instead of within the >>> opensm header file, so that the definitions are available to >>> applications other than opensm. >> My preference would be in addition to rather than instead of. In the >> future once there is libibumad release in the field for some time with >> these headers, then OpenSM can migrate definitions as makes sense. >> >> -- Hal > OK, so shall I send a v4 patch with both header files or can I do a > second separate patch > for the umad_sm.h file ? >>From my perspective, a second patch for umad_sm.h would suffice. Thanks. -- Hal > Line > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html