From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH libmlx4 v6 1/2] libmlx4: Infra-structure changes to support verbs extensions Date: Tue, 04 Jun 2013 15:01:39 -0500 Message-ID: <51AE47A3.5060802@opengridcomputing.com> References: <1364332591-22866-1-git-send-email-sean.hefty@intel.com> <51AE4288.4010505@opengridcomputing.com> <1828884A29C6694DAF28B7E6B8A823736FD2CF18@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1828884A29C6694DAF28B7E6B8A823736FD2CF18-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org" , Yishai Hadas , Tzahi Oved List-Id: linux-rdma@vger.kernel.org On 6/4/2013 2:46 PM, Hefty, Sean wrote: >>> + >>> #ifdef HAVE_IBV_REGISTER_DRIVER >>> static __attribute__((constructor)) void mlx4_register_driver(void) >>> { >>> - ibv_register_driver("mlx4", mlx4_driver_init); >>> + verbs_register_driver("mlx4", mlx4_driver_init); >>> + >>> } >>> #else >> Shouldn't ibv_register_driver() need to be called in the lib constructor >> function if HAVE_IBV_REGISTER_DRIVER is not defined? > ? If HAVE_IBV_REGISTER_DRIVER is not defined, then we can't call ibv_register_driver... I thought HAVE_IBV_REGISTER_DRIVER was something new for deciding if the lib should call verbs_register_driver(). > We should just remove the HAVE_IBV_... check completely, since with this change, libmlx4 requires an updated version of libibverbs. Ah. I was thinking it would use the old interface if it was compiled against a libibverbs that didn't support the extensions. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html