* [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency
@ 2013-06-12 11:04 Hal Rosenstock
[not found] ` <51B855AF.1070607-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Hal Rosenstock @ 2013-06-12 11:04 UTC (permalink / raw)
To: Ira Weiny
Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
Doron Tsur
Found-by: Doron Tsur <doront-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/libibnetdisc/Makefile.am b/libibnetdisc/Makefile.am
index d05604f..2cfcc33 100644
--- a/libibnetdisc/Makefile.am
+++ b/libibnetdisc/Makefile.am
@@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband
test_testleaks_SOURCES = test/testleaks.c
test_testleaks_CFLAGS = -Wall $(DBGFLAGS)
test_testleaks_LDFLAGS = -libnetdisc
+test_testleaks_DEPENDENCIES = libibnetdisc.la
libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \
$(srcdir)/include/infiniband/ibnetdisc_osd.h
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <51B855AF.1070607-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]
* RE: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency [not found] ` <51B855AF.1070607-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> @ 2013-06-12 18:25 ` Weiny, Ira [not found] ` <2807E5FD2F6FDA4886F6618EAC48510E0207CCEF-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Weiny, Ira @ 2013-06-12 18:25 UTC (permalink / raw) To: Hal Rosenstock Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org), Doron Tsur What is the error which this fixed? I would think that the test_testleaks_LDFLAGS would take care of this? Ira > -----Original Message----- > From: Hal Rosenstock [mailto:hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org] > Sent: Wednesday, June 12, 2013 4:04 AM > To: Weiny, Ira > Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org); Doron Tsur > Subject: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing > makefile dependency > > > Found-by: Doron Tsur <doront-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> > > Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> > --- > diff --git a/libibnetdisc/Makefile.am b/libibnetdisc/Makefile.am index > d05604f..2cfcc33 100644 > --- a/libibnetdisc/Makefile.am > +++ b/libibnetdisc/Makefile.am > @@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband > test_testleaks_SOURCES = test/testleaks.c test_testleaks_CFLAGS = -Wall > $(DBGFLAGS) test_testleaks_LDFLAGS = -libnetdisc > +test_testleaks_DEPENDENCIES = libibnetdisc.la > > libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \ > $(srcdir)/include/infiniband/ibnetdisc_osd.h -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <2807E5FD2F6FDA4886F6618EAC48510E0207CCEF-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>]
* Re: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency [not found] ` <2807E5FD2F6FDA4886F6618EAC48510E0207CCEF-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> @ 2013-06-12 18:31 ` Hal Rosenstock [not found] ` <51B8BE92.7000805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Hal Rosenstock @ 2013-06-12 18:31 UTC (permalink / raw) To: Weiny, Ira Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org), Doron Tsur On 6/12/2013 2:25 PM, Weiny, Ira wrote: > What is the error which this fixed? It's an issue when parallel make is used (make -j) where this library might not have completed building first. > I would think that the test_testleaks_LDFLAGS would take care of this? I don't think so. -- Hal > Ira > >> -----Original Message----- >> From: Hal Rosenstock [mailto:hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org] >> Sent: Wednesday, June 12, 2013 4:04 AM >> To: Weiny, Ira >> Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org); Doron Tsur >> Subject: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing >> makefile dependency >> >> >> Found-by: Doron Tsur <doront-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> >> >> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> >> --- >> diff --git a/libibnetdisc/Makefile.am b/libibnetdisc/Makefile.am index >> d05604f..2cfcc33 100644 >> --- a/libibnetdisc/Makefile.am >> +++ b/libibnetdisc/Makefile.am >> @@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband >> test_testleaks_SOURCES = test/testleaks.c test_testleaks_CFLAGS = -Wall >> $(DBGFLAGS) test_testleaks_LDFLAGS = -libnetdisc >> +test_testleaks_DEPENDENCIES = libibnetdisc.la >> >> libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \ >> $(srcdir)/include/infiniband/ibnetdisc_osd.h > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <51B8BE92.7000805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]
* RE: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency [not found] ` <51B8BE92.7000805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> @ 2013-06-12 19:00 ` Weiny, Ira 0 siblings, 0 replies; 4+ messages in thread From: Weiny, Ira @ 2013-06-12 19:00 UTC (permalink / raw) To: Hal Rosenstock Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org), Doron Tsur > -----Original Message----- > From: Hal Rosenstock [mailto:hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org] > Subject: Re: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing > makefile dependency > > On 6/12/2013 2:25 PM, Weiny, Ira wrote: > > What is the error which this fixed? > > It's an issue when parallel make is used (make -j) where this library might not > have completed building first. Ok, I've never hit this, just luck I guess. ;-) > > > I would think that the test_testleaks_LDFLAGS would take care of this? > > I don't think so. Ok, seems reasonable. Thanks, applied, Ira > > -- Hal > > > Ira > > > >> -----Original Message----- > >> From: Hal Rosenstock [mailto:hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org] > >> Sent: Wednesday, June 12, 2013 4:04 AM > >> To: Weiny, Ira > >> Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org); Doron Tsur > >> Subject: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add > >> missing makefile dependency > >> > >> > >> Found-by: Doron Tsur <doront-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> > >> > >> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> > >> --- > >> diff --git a/libibnetdisc/Makefile.am b/libibnetdisc/Makefile.am > >> index > >> d05604f..2cfcc33 100644 > >> --- a/libibnetdisc/Makefile.am > >> +++ b/libibnetdisc/Makefile.am > >> @@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband > >> test_testleaks_SOURCES = test/testleaks.c test_testleaks_CFLAGS = > >> -Wall > >> $(DBGFLAGS) test_testleaks_LDFLAGS = -libnetdisc > >> +test_testleaks_DEPENDENCIES = libibnetdisc.la > >> > >> libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \ > >> $(srcdir)/include/infiniband/ibnetdisc_osd.h > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-12 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-12 11:04 [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency Hal Rosenstock
[not found] ` <51B855AF.1070607-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-06-12 18:25 ` Weiny, Ira
[not found] ` <2807E5FD2F6FDA4886F6618EAC48510E0207CCEF-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-06-12 18:31 ` Hal Rosenstock
[not found] ` <51B8BE92.7000805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-06-12 19:00 ` Weiny, Ira
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox