Re: [PATCH] IB/srp: Maintain a single connection per I_T nexus

[Sebastian Riemer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>]

Hi all,

as proposed by Or, let's discuss this on the mailing list.

This is a fundamental change required for everything related to
multipathing. It influences automatic reconnect patches which will
follow. So let's agree on the right solution here first before looking
at other patches.

In my opinion the 'add_target' sysfs attribute shouldn't be used for any
manual reconnect as well. This is why my patch rejects the double login
attempt instead of reconnecting an existing connection.
This can help to find scripting issues and things like this. We can't
expect that all users are using the srp-tools.

Please compare with Bart's version and let's discuss this here.
https://github.com/bvanassche/ib_srp-backport/commit/7d8774ff58d489858b1c046b2bf01b4e84e8dd9b

Cheers,
Sebastian


On 12.06.2013 13:29, Sebastian Riemer wrote:
> The sysfs attribute 'add_target' may not be used for multiple logins to
> the same target. If doing so with multipathing, this crashes the
> multipath-tools. Furthermore, we want to prevent the possibility of data
> corruption here. If manual reconnect is necessary, then the user can use
> the 'delete' sysfs attribute of the remote port before connecting.
> 
> Note: The function srp_conn_unique() has been taken from Bart Van Assche.


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html