From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hal Rosenstock Subject: [PATCH infiniband-diags 2/6] ibstat.c: fix buffer-not-null-terminated Date: Wed, 12 Jun 2013 09:55:32 -0400 Message-ID: <51B87DD4.9040005@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ira Weiny Cc: "linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)" , Dan Ben-Yosef List-Id: linux-rdma@vger.kernel.org From: Dan Ben Yosef Buffer may not have a null terminator if the source string's length is equal to the buffer size. Signed-off-by: Dan Ben Yosef Signed-off-by: Hal Rosenstock --- src/ibstat.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/ibstat.c b/src/ibstat.c index 665bb0a..acb9e8e 100644 --- a/src/ibstat.c +++ b/src/ibstat.c @@ -279,6 +279,7 @@ int main(int argc, char *argv[]) int dev_port = -1; int n, i; + memset(names, 0, sizeof(names[0][0] * UMAD_MAX_DEVICES * UMAD_CA_NAME_LEN)); const struct ibdiag_opt opts[] = { {"list_of_cas", 'l', 0, NULL, "list all IB devices"}, {"short", 's', 0, NULL, "short output"}, @@ -314,7 +315,7 @@ int main(int argc, char *argv[]) if (i >= n) IBPANIC("'%s' IB device can't be found", argv[0]); - strncpy(names[i], argv[0], sizeof names[i]); + strncpy(names[i], argv[0], sizeof names[i]-1); n = 1; } -- 1.7.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html