* [PATCH infiniband-diags 4/6] ibsysstat.c: fix resource leak
@ 2013-06-12 13:55 Hal Rosenstock
[not found] ` <51B87DDF.1090205-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Hal Rosenstock @ 2013-06-12 13:55 UTC (permalink / raw)
To: Ira Weiny
Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
Dan Ben-Yosef
From: Dan Ben Yosef <danby-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Memory leak.
Signed-off-by: Dan Ben Yosef <danby-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
src/ibsysstat.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/ibsysstat.c b/src/ibsysstat.c
index eb876d4..c1438c1 100644
--- a/src/ibsysstat.c
+++ b/src/ibsysstat.c
@@ -271,8 +271,10 @@ int build_cpuinfo(void)
while (fgets(line, sizeof(line) - 1, f)) {
if (!strncmp(line, "processor\t", 10)) {
ncpu++;
- if (ncpu > MAX_CPUS)
+ if (ncpu > MAX_CPUS) {
+ fclose(f);
return MAX_CPUS;
+ }
continue;
}
--
1.7.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH infiniband-diags 4/6] ibsysstat.c: fix resource leak
[not found] ` <51B87DDF.1090205-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2013-06-12 21:27 ` Ira Weiny
0 siblings, 0 replies; 2+ messages in thread
From: Ira Weiny @ 2013-06-12 21:27 UTC (permalink / raw)
To: Hal Rosenstock
Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
Dan Ben-Yosef
On Wed, 12 Jun 2013 09:55:43 -0400
Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
> From: Dan Ben Yosef <danby-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Thanks applied!
Ira
>
> Memory leak.
>
> Signed-off-by: Dan Ben Yosef <danby-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> src/ibsysstat.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/ibsysstat.c b/src/ibsysstat.c
> index eb876d4..c1438c1 100644
> --- a/src/ibsysstat.c
> +++ b/src/ibsysstat.c
> @@ -271,8 +271,10 @@ int build_cpuinfo(void)
> while (fgets(line, sizeof(line) - 1, f)) {
> if (!strncmp(line, "processor\t", 10)) {
> ncpu++;
> - if (ncpu > MAX_CPUS)
> + if (ncpu > MAX_CPUS) {
> + fclose(f);
> return MAX_CPUS;
> + }
> continue;
> }
>
> --
> 1.7.8.2
>
--
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-12 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-12 13:55 [PATCH infiniband-diags 4/6] ibsysstat.c: fix resource leak Hal Rosenstock
[not found] ` <51B87DDF.1090205-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-06-12 21:27 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox