From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: "Weiny, Ira" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma
(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Doron Tsur <doront-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency
Date: Wed, 12 Jun 2013 14:31:46 -0400 [thread overview]
Message-ID: <51B8BE92.7000805@dev.mellanox.co.il> (raw)
In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E0207CCEF-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 6/12/2013 2:25 PM, Weiny, Ira wrote:
> What is the error which this fixed?
It's an issue when parallel make is used (make -j) where this library
might not have completed building first.
> I would think that the test_testleaks_LDFLAGS would take care of this?
I don't think so.
-- Hal
> Ira
>
>> -----Original Message-----
>> From: Hal Rosenstock [mailto:hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org]
>> Sent: Wednesday, June 12, 2013 4:04 AM
>> To: Weiny, Ira
>> Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org); Doron Tsur
>> Subject: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing
>> makefile dependency
>>
>>
>> Found-by: Doron Tsur <doront-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> ---
>> diff --git a/libibnetdisc/Makefile.am b/libibnetdisc/Makefile.am index
>> d05604f..2cfcc33 100644
>> --- a/libibnetdisc/Makefile.am
>> +++ b/libibnetdisc/Makefile.am
>> @@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband
>> test_testleaks_SOURCES = test/testleaks.c test_testleaks_CFLAGS = -Wall
>> $(DBGFLAGS) test_testleaks_LDFLAGS = -libnetdisc
>> +test_testleaks_DEPENDENCIES = libibnetdisc.la
>>
>> libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \
>> $(srcdir)/include/infiniband/ibnetdisc_osd.h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-12 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 11:04 [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency Hal Rosenstock
[not found] ` <51B855AF.1070607-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-06-12 18:25 ` Weiny, Ira
[not found] ` <2807E5FD2F6FDA4886F6618EAC48510E0207CCEF-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-06-12 18:31 ` Hal Rosenstock [this message]
[not found] ` <51B8BE92.7000805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-06-12 19:00 ` Weiny, Ira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B8BE92.7000805@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=doront-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox