From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hal Rosenstock Subject: Re: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing makefile dependency Date: Wed, 12 Jun 2013 14:31:46 -0400 Message-ID: <51B8BE92.7000805@dev.mellanox.co.il> References: <51B855AF.1070607@dev.mellanox.co.il> <2807E5FD2F6FDA4886F6618EAC48510E0207CCEF@CRSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E0207CCEF-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Weiny, Ira" Cc: "linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)" , Doron Tsur List-Id: linux-rdma@vger.kernel.org On 6/12/2013 2:25 PM, Weiny, Ira wrote: > What is the error which this fixed? It's an issue when parallel make is used (make -j) where this library might not have completed building first. > I would think that the test_testleaks_LDFLAGS would take care of this? I don't think so. -- Hal > Ira > >> -----Original Message----- >> From: Hal Rosenstock [mailto:hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org] >> Sent: Wednesday, June 12, 2013 4:04 AM >> To: Weiny, Ira >> Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org); Doron Tsur >> Subject: [PATCH infiniband-diags] libibnetdisc/Makefile.am: Add missing >> makefile dependency >> >> >> Found-by: Doron Tsur >> >> Signed-off-by: Hal Rosenstock >> --- >> diff --git a/libibnetdisc/Makefile.am b/libibnetdisc/Makefile.am index >> d05604f..2cfcc33 100644 >> --- a/libibnetdisc/Makefile.am >> +++ b/libibnetdisc/Makefile.am >> @@ -35,6 +35,7 @@ libibnetdiscincludedir = $(includedir)/infiniband >> test_testleaks_SOURCES = test/testleaks.c test_testleaks_CFLAGS = -Wall >> $(DBGFLAGS) test_testleaks_LDFLAGS = -libnetdisc >> +test_testleaks_DEPENDENCIES = libibnetdisc.la >> >> libibnetdiscinclude_HEADERS = $(srcdir)/include/infiniband/ibnetdisc.h \ >> $(srcdir)/include/infiniband/ibnetdisc_osd.h > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html