From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Wang Subject: RE: [PATCH 07/14] scsi_transport_srp: Add transport layer error handling Date: Wed, 19 Jun 2013 15:44:42 +0200 Message-ID: <51C1B5CA.2030302@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Sender: linux-scsi-owner@vger.kernel.org To: Bart Van Assche Cc: David Dillow , Vu Pham , Sebastian Riemer , linux-rdma , linux-scsi , James Bottomley , Roland Dreier List-Id: linux-rdma@vger.kernel.org > + /* > + * It can occur that after fast_io_fail_tmo expired and before > + * dev_loss_tmo expired that the SCSI error handler has > + * offlined one or more devices. scsi_target_unblock() doesn't > + * change the state of these devices into running, so do that > + * explicitly. > + */ > + spin_lock_irq(shost->host_lock); > + __shost_for_each_device(sdev, shost) > + if (sdev->sdev_state == SDEV_OFFLINE) > + sdev->sdev_state = SDEV_RUNNING; > + spin_unlock_irq(shost->host_lock); Hello Bart, Do you have test case to verify this behaviour? Regards, Jack