From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma
(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 12/15 ibacm] Increase buffer space for inet_ntop from 32 to INET6_ADDRSTRLEN
Date: Fri, 21 Jun 2013 07:02:36 -0400 [thread overview]
Message-ID: <51C432CC.7010205@dev.mellanox.co.il> (raw)
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
linux/acme_linux.c | 2 +-
src/acm.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux/acme_linux.c b/linux/acme_linux.c
index 1039645..ef5b107 100644
--- a/linux/acme_linux.c
+++ b/linux/acme_linux.c
@@ -149,7 +149,7 @@ int gen_addr_ip(FILE *f)
{
struct ifconf *ifc;
struct ifreq *ifr;
- char ip[sizeof "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff"];
+ char ip[INET6_ADDRSTRLEN];
int s, ret, dev_index, i, len;
uint16_t pkey;
uint8_t port;
diff --git a/src/acm.c b/src/acm.c
index 49723ad..55d9e2d 100644
--- a/src/acm.c
+++ b/src/acm.c
@@ -2790,7 +2790,7 @@ static int acm_assign_ep_names(struct acm_ep *ep)
FILE *faddr;
char *dev_name;
char s[120];
- char dev[32], addr[32], pkey_str[8];
+ char dev[32], addr[INET6_ADDRSTRLEN], pkey_str[8];
uint16_t pkey;
uint8_t type;
int port, index = 0;
@@ -2809,7 +2809,7 @@ static int acm_assign_ep_names(struct acm_ep *ep)
if (s[0] == '#')
continue;
- if (sscanf(s, "%32s%32s%d%8s", addr, dev, &port, pkey_str) != 4)
+ if (sscanf(s, "%46s%32s%d%8s", addr, dev, &port, pkey_str) != 4)
continue;
acm_log(2, "%s", s);
--
1.7.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2013-06-21 11:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C432CC.7010205@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox