Re: [PATCH 07/14] scsi_transport_srp: Add transport layer error handling

[Jack Wang <jinpu.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>]

On 06/24/2013 05:50 PM, Bart Van Assche wrote:
> On 06/24/13 15:48, Jack Wang wrote:
>>> I'm not sure it's possible to avoid such a race without introducing
>>> a new mutex. How about something like the (untested) SCSI core patch
>>> below, and invoking scsi_block_eh() and scsi_unblock_eh() around any
>>> reconnect activity not initiated from the SCSI EH thread ?
>>>
>>> [PATCH] Add scsi_block_eh() and scsi_unblock_eh()
>>>
>> Hi Bart,
>>
>> The description doesn't match the code at all, do you mean try to
>> serialize the reconnect activity with this new block_eh_mutex?
> 
> In case it wasn't clear, the actual scsi_block_eh() and
> scsi_unblock_eh() calls aren't present in the patch I posted, only their
> implementation.
As the patch title is "Add scsi_block_eh() and scsi_unblock_eh()", so I
asked, thanks for explanation.
> 
> P.S.: please fix your e-mail client such that it does not break e-mail
> threading. There are no "In-Reply-To:" tags in the header of your e-mails.
> 
Sorry for inconvenient, will fix it.

Thanks,
Jack
> Thanks,
> 
> Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html