From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Hadar Hen Zion <hadarh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
matanb <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH V1 for-next 3/4] IB/core: Export ib_create/destroy_flow through uverbs
Date: Tue, 25 Jun 2013 08:21:10 +0300 [thread overview]
Message-ID: <51C928C6.3080306@mellanox.com> (raw)
In-Reply-To: <CAL1RGDUqKNkGCeW6pguEeWR8i7-CaLOq2Kria8vFkyY4H4fmgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 25/06/2013 00:10, Roland Dreier wrote:
> On Tue, Jun 11, 2013 at 4:42 AM, Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
>> +struct ib_kern_flow {
>> + struct ib_device *device;
>> + struct ib_uobject *uobject;
>> + void *flow_context;
>> +};
> I don't think it makes sense to put a structure with kernel pointers
> in it into an include file under include/uapi. For one thing the size
> of pointers depends on whether userspace is 32-bit or 64-bit (but of
> course there are many other reasons why this will break).
good catch, will look && fix up
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-25 5:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 11:42 [PATCH V1 for-next 0/4] Add receive Flow Steering support Or Gerlitz
[not found] ` <1370950973-11716-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-06-11 11:42 ` [PATCH V1 for-next 1/4] IB/core: " Or Gerlitz
2013-06-11 11:42 ` [PATCH V1 for-next 2/4] IB/core: Infra-structure to support verbs extensions through uverbs Or Gerlitz
2013-06-11 11:42 ` [PATCH V1 for-next 3/4] IB/core: Export ib_create/destroy_flow " Or Gerlitz
[not found] ` <1370950973-11716-4-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-06-24 21:10 ` Roland Dreier
[not found] ` <CAL1RGDUqKNkGCeW6pguEeWR8i7-CaLOq2Kria8vFkyY4H4fmgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-25 5:21 ` Or Gerlitz [this message]
2013-06-11 11:42 ` [PATCH V1 for-next 4/4] IB/mlx4: Add receive Flow Steering support Or Gerlitz
2013-06-17 17:33 ` [PATCH V1 for-next 0/4] " Or Gerlitz
2013-06-24 15:57 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C928C6.3080306@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=hadarh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox