From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH V1 for-next 3/4] IB/core: Export ib_create/destroy_flow through uverbs Date: Tue, 25 Jun 2013 08:21:10 +0300 Message-ID: <51C928C6.3080306@mellanox.com> References: <1370950973-11716-1-git-send-email-ogerlitz@mellanox.com> <1370950973-11716-4-git-send-email-ogerlitz@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Hadar Hen Zion , matanb List-Id: linux-rdma@vger.kernel.org On 25/06/2013 00:10, Roland Dreier wrote: > On Tue, Jun 11, 2013 at 4:42 AM, Or Gerlitz wrote: >> +struct ib_kern_flow { >> + struct ib_device *device; >> + struct ib_uobject *uobject; >> + void *flow_context; >> +}; > I don't think it makes sense to put a structure with kernel pointers > in it into an include file under include/uapi. For one thing the size > of pointers depends on whether userspace is 32-bit or 64-bit (but of > course there are many other reasons why this will break). good catch, will look && fix up Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html