From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Riemer Subject: Re: [PATCH 01/14] IB/srp: Fix remove_one crash due to resource exhaustion Date: Fri, 28 Jun 2013 09:41:18 +0200 Message-ID: <51CD3E1E.6060301@profitbricks.com> References: <51B87501.4070005@acm.org> <51B875A4.7040903@acm.org> <1372366870.32164.30.camel@frustration.ornl.gov> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: David Dillow , Bart Van Assche , Vu Pham , linux-rdma , Dotan Barak , Eli Cohen List-Id: linux-rdma@vger.kernel.org On 28.06.2013 01:45, Roland Dreier wrote: > On Thu, Jun 27, 2013 at 2:01 PM, David Dillow wrote: >> On Wed, 2013-06-12 at 15:20 +0200, Bart Van Assche wrote: >>> If the add_one callback fails during driver load no resources are >>> allocated so there isn't a need to release any resources. Trying >>> to clean the resource may lead to the following kernel panic: >> >> Acked-by: David Dillow > > Thanks, I've queued up the 1, 3, and 4/14 patches that Dave acked so far. Hi Roland, did you queue 3 without the target->transport_offline check? Otherwise I can't agree on that. 1 and 4 are also for me okay. Cheers, Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html