public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Roland Dreier <roland@kernel.org>
Cc: David Dillow <dave@thedillows.org>,
	Vu Pham <vuhuong@mellanox.com>,
	Sebastian Riemer <sebastian.riemer@profitbricks.com>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH v2 12/15] IB/srp: Fail SCSI commands silently
Date: Fri, 28 Jun 2013 14:56:50 +0200	[thread overview]
Message-ID: <51CD8812.20107@acm.org> (raw)
In-Reply-To: <51CD856A.3010102@acm.org>

From: Sebastian Riemer <sebastian.riemer@profitbricks.com>

Avoid that path failover in a multipath setup causes the SCSI layer
to generate kernel messages about SCSI command failures. This patch
speeds up SRP initiator operation significantly when monitoring
kernel messages over a serial port.

[bvanassche: Changed patch description]
Signed-off-by: Sebastian Riemer <sebastian.riemer@profitbricks.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Roland Dreier <roland@purestorage.com>
Cc: David Dillow <dillowda@ornl.gov>
Cc: Vu Pham <vu@mellanox.com>
---
 drivers/infiniband/ulp/srp/ib_srp.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index a8cc427..e77176e 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -757,6 +757,7 @@ static void srp_finish_req(struct srp_target_port *target,
 
 	if (scmnd) {
 		srp_free_req(target, req, scmnd, 0);
+		scmnd->request->cmd_flags |= REQ_QUIET;
 		scmnd->result = result;
 		scmnd->scsi_done(scmnd);
 	}
@@ -1438,6 +1439,7 @@ static int srp_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *scmnd)
 
 	result = srp_chkready(target->rport);
 	if (unlikely(result)) {
+		scmnd->request->cmd_flags |= REQ_QUIET;
 		scmnd->result = result;
 		scmnd->scsi_done(scmnd);
 		return 0;
@@ -1843,6 +1845,7 @@ static int srp_abort(struct scsi_cmnd *scmnd)
 	else
 		ret = FAILED;
 	srp_free_req(target, req, scmnd, 0);
+	scmnd->request->cmd_flags |= REQ_QUIET;
 	scmnd->result = DID_ABORT << 16;
 	scmnd->scsi_done(scmnd);
 
-- 
1.7.10.4


  parent reply	other threads:[~2013-06-28 12:56 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 12:45 [PATCH v2 0/15] IB SRP initiator patches for kernel 3.11 Bart Van Assche
2013-06-28 12:53 ` [PATCH v2 08/15] scsi_transport_srp: Add transport layer error handling Bart Van Assche
2013-06-30 21:05   ` David Dillow
     [not found]     ` <1372626334.12468.34.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2013-07-01  7:01       ` Bart Van Assche
     [not found]         ` <51D12941.3050105-HInyCGIudOg@public.gmane.org>
2013-07-01 11:19           ` David Dillow
2013-06-28 12:56 ` Bart Van Assche [this message]
     [not found]   ` <51CD8812.20107-HInyCGIudOg@public.gmane.org>
2013-06-30 21:25     ` [PATCH v2 12/15] IB/srp: Fail SCSI commands silently David Dillow
     [not found] ` <51CD856A.3010102-HInyCGIudOg@public.gmane.org>
2013-06-28 12:46   ` [PATCH v2 01/15] IB/srp: Fix remove_one crash due to resource exhaustion Bart Van Assche
2013-06-28 12:48   ` [PATCH v2 02/15] IB/srp: Fix race between srp_queuecommand() and srp_claim_req() Bart Van Assche
     [not found]     ` <51CD8604.5010801-HInyCGIudOg@public.gmane.org>
2013-06-28 14:42       ` Sebastian Riemer
     [not found]         ` <51CDA0CD.6060504-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2013-06-28 14:51           ` Bart Van Assche
     [not found]             ` <51CDA2E5.2010704-HInyCGIudOg@public.gmane.org>
2013-06-28 15:08               ` Sebastian Riemer
2013-06-30 19:59       ` David Dillow
     [not found]         ` <1372622347.12468.9.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2013-07-01  7:10           ` Bart Van Assche
2013-06-28 12:49   ` [PATCH v2 03/15] IB/srp: Avoid that srp_reset_host() is skipped after a TL error Bart Van Assche
     [not found]     ` <51CD8644.5080600-HInyCGIudOg@public.gmane.org>
2013-06-30 20:00       ` David Dillow
2013-06-28 12:49   ` [PATCH v2 04/15] IB/srp: Fail I/O fast if target offline Bart Van Assche
     [not found]     ` <51CD8676.6080205-HInyCGIudOg@public.gmane.org>
2013-06-30 20:02       ` David Dillow
2013-07-01  9:07       ` Sebastian Riemer
     [not found]         ` <51D146EE.6010209-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2013-07-01 11:33           ` Bart Van Assche
     [not found]             ` <51D16918.60600-HInyCGIudOg@public.gmane.org>
2013-07-01 11:53               ` Sebastian Riemer
2013-07-01  9:25       ` Sebastian Riemer
     [not found]         ` <51D14AF1.4000803-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2013-07-01 11:38           ` Bart Van Assche
     [not found]             ` <51D16A39.4050709-HInyCGIudOg@public.gmane.org>
2013-07-01 12:31               ` Sebastian Riemer
     [not found]                 ` <51D176B5.90609-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2013-07-01 12:57                   ` Bart Van Assche
2013-07-02  8:30       ` Sebastian Riemer
2013-06-28 12:50   ` [PATCH v2 05/15] IB/srp: Skip host settle delay Bart Van Assche
2013-06-28 12:51   ` [PATCH v2 06/15] IB/srp: Maintain a single connection per I_T nexus Bart Van Assche
     [not found]     ` <51CD86CE.8080804-HInyCGIudOg@public.gmane.org>
2013-06-30 20:10       ` David Dillow
2013-06-28 12:52   ` [PATCH v2 07/15] IB/srp: Keep rport as long as the IB transport layer Bart Van Assche
2013-06-30 21:06     ` David Dillow
2013-06-28 12:54   ` [PATCH v2 09/15] IB/srp: Add srp_terminate_io() Bart Van Assche
     [not found]     ` <51CD877E.80606-HInyCGIudOg@public.gmane.org>
2013-06-30 21:10       ` David Dillow
2013-06-28 12:55   ` [PATCH v2 10/15] IB/srp: Use SRP transport layer error recovery Bart Van Assche
     [not found]     ` <51CD87A9.2090702-HInyCGIudOg@public.gmane.org>
2013-06-30 21:20       ` David Dillow
2013-06-28 12:55   ` [PATCH v2 11/15] IB/srp: Start timers if a transport layer error occurs Bart Van Assche
     [not found]     ` <51CD87D7.3050300-HInyCGIudOg@public.gmane.org>
2013-06-30 21:21       ` David Dillow
2013-06-28 12:57   ` [PATCH v2 13/15] IB/srp: Make HCA completion vector configurable Bart Van Assche
     [not found]     ` <51CD8846.4070400-HInyCGIudOg@public.gmane.org>
2013-06-30 21:26       ` David Dillow
2013-06-28 12:58   ` [PATCH v2 14/15] IB/srp: Make transport layer retry count configurable Bart Van Assche
     [not found]     ` <51CD8876.9020307-HInyCGIudOg@public.gmane.org>
2013-06-30 21:48       ` David Dillow
     [not found]         ` <1372628891.12468.52.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2013-07-01  8:18           ` Bart Van Assche
     [not found]             ` <51D13B52.5060803-HInyCGIudOg@public.gmane.org>
2013-07-01 11:26               ` David Dillow
     [not found]                 ` <1372677965.12468.57.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2013-07-01 11:44                   ` Bart Van Assche
2013-07-02 19:18                   ` Jason Gunthorpe
     [not found]                     ` <20130702191842.GD14625-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2013-07-03 14:26                       ` David Dillow
2013-06-28 12:59   ` [PATCH v2 15/15] IB/srp: Bump driver version and release date Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CD8812.20107@acm.org \
    --to=bvanassche@acm.org \
    --cc=dave@thedillows.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=roland@kernel.org \
    --cc=sebastian.riemer@profitbricks.com \
    --cc=vuhuong@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox