From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jack Morgenstein
<jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Subject: Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices
Date: Wed, 3 Jul 2013 19:41:45 +0300 [thread overview]
Message-ID: <51D45449.5010604@mellanox.com> (raw)
In-Reply-To: <CAL1RGDX5mHj5oVqFhQ4Ssr25jpL4rV2Tv=zXvLOZfwupJ0gqJw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 01/07/2013 20:49, Roland Dreier wrote:
> - I think the active flag for the health check timer is unnecessary.
> It can just be stopped with del_timer_sync().
Hi Roland
Jack looked on this comment/code and he says that the active flag is used
to prevent re-scheduling the timer from inside the timer handling routine.
In the kernel, the comment header in the source file for del_timer_sync
explicitly states that re-scheduling the timer must be prevented,
or the sync is useless:Callers must prevent restarting of the timer,
otherwise
this function is meaningless
So we believe that code should remain.
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-07-03 16:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 12:02 [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices Eli Cohen
[not found] ` <1371384149-24558-1-git-send-email-eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-06-16 12:02 ` [PATCH for-next 1/8] mlx5: Mellanox Connect-IB driver part 1/8 Eli Cohen
2013-06-16 12:02 ` [PATCH for-next 2/8] mlx5: Mellanox Connect-IB driver part 2/8 Eli Cohen
2013-06-16 12:02 ` [PATCH for-next 3/8] mlx5: Mellanox Connect-IB driver part 3/8 Eli Cohen
2013-06-16 12:02 ` [PATCH for-next 4/8] mlx5: Mellanox Connect-IB driver part 4/8 Eli Cohen
2013-06-16 12:02 ` [PATCH for-next 5/8] mlx5: Mellanox Connect-IB driver part 5/8 Eli Cohen
2013-06-16 12:02 ` [PATCH for-next 6/8] mlx5: Mellanox Connect-IB driver part 6/8 Eli Cohen
2013-06-16 12:02 ` [PATCH for-next 7/8] mlx5: Mellanox Connect-IB driver part 7/8 Eli Cohen
2013-06-16 12:02 ` [PATCH for-next 8/8] mlx5: Mellanox Connect-IB driver part 8/8 Eli Cohen
2013-06-20 14:44 ` [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices Or Gerlitz
[not found] ` <51C31561.3040507-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-06-26 0:14 ` David Miller
[not found] ` <CAJZOPZ+NQa3CWnw3rZQh2UuwdrNhiwtVSyuk9D9YtwfQQ9e1XA@mail.gmail.com>
[not found] ` <CAJZOPZ+NQa3CWnw3rZQh2UuwdrNhiwtVSyuk9D9YtwfQQ9e1XA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-28 13:22 ` Or Gerlitz
[not found] ` <CAJZOPZKLb9k1xXkTnrtzYKpwrSJDQgBpONUVCp3et36JeaEi-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-01 17:49 ` Roland Dreier
2013-07-01 18:03 ` Joe Perches
2013-07-01 18:11 ` Roland Dreier
2013-07-01 20:19 ` Joe Perches
2013-07-01 21:20 ` Roland Dreier
[not found] ` <CAL1RGDVgSucpRhyxBZDVeLO+Q+Y7HuPsDjUy6kaFMoL3E8s77g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-01 21:53 ` Joe Perches
2013-07-02 21:03 ` Or Gerlitz
[not found] ` <CAL1RGDX5mHj5oVqFhQ4Ssr25jpL4rV2Tv=zXvLOZfwupJ0gqJw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-01 18:03 ` Roland Dreier
[not found] ` <CAL1RGDXsgo9mHteu5MwqnoULd1jqE_LDZ=YfHMH4J=pRZqeLgQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-02 21:15 ` Or Gerlitz
2013-07-01 21:22 ` Roland Dreier
[not found] ` <CAL1RGDVQD_Uk0ZJse=Xc74nzAeUMAwYjYAhaPp2OJvgBD=TcOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-02 20:59 ` Or Gerlitz
2013-07-03 16:41 ` Or Gerlitz [this message]
[not found] ` <51D45449.5010604-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-07-03 19:26 ` Roland Dreier
2013-07-03 20:25 ` Or Gerlitz
[not found] ` <CAL1RGDU0JiGPFEAu87JbxxbHWbgZVsRz1qbz4BvqbCJU9RtRAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-07 12:08 ` Jack Morgenstein
2013-07-02 21:36 ` Or Gerlitz
2013-06-28 13:23 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D45449.5010604@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox