From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices Date: Wed, 3 Jul 2013 19:41:45 +0300 Message-ID: <51D45449.5010604@mellanox.com> References: <1371384149-24558-1-git-send-email-eli@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: Or Gerlitz , Eli Cohen , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Eli Cohen , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jack Morgenstein List-Id: linux-rdma@vger.kernel.org On 01/07/2013 20:49, Roland Dreier wrote: > - I think the active flag for the health check timer is unnecessary. > It can just be stopped with del_timer_sync(). Hi Roland Jack looked on this comment/code and he says that the active flag is used to prevent re-scheduling the timer from inside the timer handling routine. In the kernel, the comment header in the source file for del_timer_sync explicitly states that re-scheduling the timer must be prevented, or the sync is useless:Callers must prevent restarting of the timer, otherwise this function is meaningless So we believe that code should remain. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html