Re: [PATCH] IB/srp: Let srp_abort() return FAST_IO_FAIL if TL offline

[Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

Bart Van Assche wrote:
> If the transport layer is offline it is more appropriate to let
> srp_abort() return FAST_IO_FAIL instead of SUCCESS.
>
> Signed-off-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
> Reported-by: Sebastian Riemer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
> Cc: David Dillow <dillowda-1Heg1YXhbW8@public.gmane.org>
> Cc: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
> Cc: Vu Pham <vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>  drivers/infiniband/ulp/srp/ib_srp.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> index 9d8b46e..f93baf8 100644
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -1753,8 +1753,7 @@ static int srp_abort(struct scsi_cmnd *scmnd)
>  	if (!req || !srp_claim_req(target, req, scmnd))
>  		return FAILED;
>  	if (srp_send_tsk_mgmt(target, req->index, scmnd->device->lun,
> -			      SRP_TSK_ABORT_TASK) == 0 ||
> -	    target->transport_offline)
> +			      SRP_TSK_ABORT_TASK) == 0)
>  		ret = SUCCESS;
>  	else if (target->transport_offline)
>  		ret = FAST_IO_FAIL;
>   
Hello Bart,

With this patch applied on top of v3, my fail-over test have run well.
Please queue it up with v4.

thanks,
-vu
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html