Re: [PATCH] ib/mad: remove Device Mgmt from RMPP class list

[Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 7/24/2013 6:10 PM, Weiny, Ira wrote:
>> -----Original Message-----
>> From: Hal Rosenstock [mailto:hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org]
>> Subject: Re: [PATCH] ib/mad: remove Device Mgmt from RMPP class list
>>
>> On 7/24/2013 5:44 PM, Ira Weiny wrote:
>>> The specification does not indicate that Device Mgmt is an RMPP class.
>>
>> See Annex 8; DevMgt class version 2 rather than 1 is currently supported.
> 
> Could older devices still return version 1?  

Yes, we can change this to support version 1 too.

> If so the kernel should allow DevMgt without RMPP, correct?

Yes. Both versions 1 and 2 DevMgt could be supported.

-- Hal

> 
> Ira
> 
>>
>> -- Hal
>>
>>> Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>> ---
>>>  drivers/infiniband/core/mad.c |    1 -
>>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/infiniband/core/mad.c
>>> b/drivers/infiniband/core/mad.c index dc3fd1e..309b507 100644
>>> --- a/drivers/infiniband/core/mad.c
>>> +++ b/drivers/infiniband/core/mad.c
>>> @@ -943,7 +943,6 @@ EXPORT_SYMBOL(ib_get_mad_data_offset);
>>>  int ib_is_mad_class_rmpp(u8 mgmt_class)  {
>>>  	if ((mgmt_class == IB_MGMT_CLASS_SUBN_ADM) ||
>>> -	    (mgmt_class == IB_MGMT_CLASS_DEVICE_MGMT) ||
>>>  	    (mgmt_class == IB_MGMT_CLASS_DEVICE_ADM) ||
>>>  	    (mgmt_class == IB_MGMT_CLASS_BIS) ||
>>>  	    ((mgmt_class >= IB_MGMT_CLASS_VENDOR_RANGE2_START) &&
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html