Re: [PATCH V8 libibverbs 1/7] Infrastructure to support verbs extensions

[Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 7/31/2013 7:52 PM, Jason Gunthorpe wrote:
> On Wed, Jul 31, 2013 at 10:27:06AM +0300, Yishai Hadas wrote:
>
>>      Looking around ibv_context usage, it's used as non const input,
>> in that case we can have only one version which takes non-const
>> input and return non-const one, preventing any silent casting as
>> below, can we agree on ?
> Fair enough.
     Thanks, will use as part of V9.
> Why are you so against the inline version?
     In V9 don't add them, macros are 2/3 lines code, seem to me 
redundant here.
     In addition verbs_get_ctx is inline so we partially have it.
>
>>      Are you fine with below definition ? any other () needed ?
>>
>>    #define verbs_set_ctx_op(_vctx, op, ptr) ({ \
>>         struct verbs_context *vctx = _vctx; \
>>         if (vctx && (vctx->sz >= sizeof(*vctx) - offsetof(struct verbs_context, op))) \
>>                 vctx->op = ptr; })
> This looks fine
     Thanks, will use as part of V9.
> Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html