From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
"leon@kernel.org" <leon@kernel.org>,
Bob Pearson <rpearsonhpe@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Mark Bloch <mbloch@nvidia.com>, Tom Talpey <tom@talpey.com>,
"tomasz.gromadzki@intel.com" <tomasz.gromadzki@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
"yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>,
"Yasunori Gotou (Fujitsu)" <y-goto@fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [for-next PATCH v6 04/10] RDMA/rxe: Allow registering persistent flag for pmem MR only
Date: Wed, 23 Nov 2022 06:12:05 +0000 [thread overview]
Message-ID: <51ce238c-7870-581e-8d29-5d802e4d7dcd@fujitsu.com> (raw)
In-Reply-To: <Y3zgzyMN71AmIFPI@nvidia.com>
On 22/11/2022 22:46, Jason Gunthorpe wrote:
> On Wed, Nov 16, 2022 at 04:19:45PM +0800, Li Zhijian wrote:
>> int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length, u64 iova,
>> int access, struct rxe_mr *mr)
>> {
>> @@ -148,16 +157,25 @@ int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length, u64 iova,
>> num_buf = 0;
>> map = mr->map;
>> if (length > 0) {
>> - buf = map[0]->buf;
>> + bool persistent_access = access & IB_ACCESS_FLUSH_PERSISTENT;
>>
>> + buf = map[0]->buf;
>> for_each_sgtable_page (&umem->sgt_append.sgt, &sg_iter, 0) {
>> + struct page *pg = sg_page_iter_page(&sg_iter);
>> +
>> + if (persistent_access && !is_pmem_page(pg)) {
>> + pr_debug("Unable to register persistent access to non-pmem device\n");
>> + err = -EINVAL;
>> + goto err_release_umem;
>
> This should use rxe_dbg_mr()
>
Good catch, thanks
Zhijian
> Jason
next prev parent reply other threads:[~2022-11-23 6:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 8:19 [for-next PATCH v6 00/10] RDMA/rxe: Add RDMA FLUSH operation Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 01/10] RDMA: Extend RDMA user ABI to support flush Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 02/10] RDMA: Extend RDMA kernel verbs " Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 03/10] RDMA/rxe: Extend rxe user " Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 04/10] RDMA/rxe: Allow registering persistent flag for pmem MR only Li Zhijian
2022-11-22 14:46 ` Jason Gunthorpe
2022-11-23 6:12 ` lizhijian [this message]
2022-11-16 8:19 ` [for-next PATCH v6 05/10] RDMA/rxe: Extend rxe packet format to support flush Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 06/10] RDMA/rxe: Implement RC RDMA FLUSH service in requester side Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 07/10] RDMA/rxe: Implement flush execution in responder side Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 08/10] RDMA/rxe: Implement flush completion Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 09/10] RDMA/cm: Make QP FLUSHABLE Li Zhijian
2022-11-22 14:52 ` Jason Gunthorpe
2022-11-23 6:07 ` lizhijian
2022-11-24 17:39 ` Jason Gunthorpe
2022-11-25 2:22 ` lizhijian
2022-11-25 14:16 ` Jason Gunthorpe
2022-11-28 10:23 ` lizhijian
2022-12-05 10:07 ` lizhijian
2022-12-05 17:12 ` Jason Gunthorpe
2022-12-07 1:25 ` lizhijian
2022-11-16 8:19 ` [for-next PATCH v6 10/10] RDMA/rxe: Enable RDMA FLUSH capability for rxe device Li Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ce238c-7870-581e-8d29-5d802e4d7dcd@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=rpearsonhpe@gmail.com \
--cc=tom@talpey.com \
--cc=tomasz.gromadzki@intel.com \
--cc=y-goto@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox