From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yishai Hadas Subject: Re: [PATCH libibverbs] XRC - Sample application issues Date: Sun, 18 Aug 2013 12:05:48 +0300 Message-ID: <52108E6C.9070908@dev.mellanox.co.il> References: <1375974336-26314-1-git-send-email-yishaih@mellanox.com> <1828884A29C6694DAF28B7E6B8A8237388CA64F6@ORSMSX109.amr.corp.intel.com> <63247C4015478741AE4981C62DF608835683DDC8@MTLDAG01.mtl.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <63247C4015478741AE4981C62DF608835683DDC8-fViJhHBwANKuSA5JZHE7gA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" , Roland Dreier , "linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)" Cc: "yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , Eli Cohen , jay.e.sternberg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Or Gerlitz , "Tzahi Oved (tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org)" List-Id: linux-rdma@vger.kernel.org On 8/16/2013 06:11 PM, Sean Hefty wrote: >> @@ -884,6 +884,13 @@ int main(int argc, char *argv[]) >> if (ctx.use_event) >> ibv_ack_cq_events(ctx.recv_cq, num_cq_events); >> >> + /* Process should wait before closing its resources to make sure >> + * latest daemon's response sent via its target QP destined to an XSRQ >> + * created by another client won't be lost. >> + * Failure to do so will cause the client to wait for that sent message >> forever. >> + * See comment on pp_post_send. >> + */ >> + sleep(1); > I dislike adding sleep calls into code. Isn't there a more robust way to handle this? In general I agree this sleep is a workaround that comes to solve a synchronization hole in this sample application. For that reason I put 5 lines comment to describe the problem and the reason for that sleep statement. Long term you could think of synchronizing all the processes through the sockets mechanism to assure they terminate when all packets are received. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html