From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org>,
Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Sebastian Riemer
<sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 3/8] IB/srp: Add srp_terminate_io()
Date: Tue, 20 Aug 2013 14:45:11 +0200 [thread overview]
Message-ID: <521364D7.3040007@acm.org> (raw)
In-Reply-To: <521363EA.8080906-HInyCGIudOg@public.gmane.org>
Finish all outstanding I/O requests after fast_io_fail_tmo expired,
which speeds up failover in a multipath setup. This patch is a
reworked version of a patch from Sebastian Riemer.
Reported-by: Sebastian Riemer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Signed-off-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
Acked-by: David Dillow <dillowda-1Heg1YXhbW8@public.gmane.org>
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Vu Pham <vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Sebastian Riemer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
---
drivers/infiniband/ulp/srp/ib_srp.c | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index de49088..37dd3fb 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -688,17 +688,29 @@ static void srp_free_req(struct srp_target_port *target,
spin_unlock_irqrestore(&target->lock, flags);
}
-static void srp_reset_req(struct srp_target_port *target, struct srp_request *req)
+static void srp_finish_req(struct srp_target_port *target,
+ struct srp_request *req, int result)
{
struct scsi_cmnd *scmnd = srp_claim_req(target, req, NULL);
if (scmnd) {
srp_free_req(target, req, scmnd, 0);
- scmnd->result = DID_RESET << 16;
+ scmnd->result = result;
scmnd->scsi_done(scmnd);
}
}
+static void srp_terminate_io(struct srp_rport *rport)
+{
+ struct srp_target_port *target = rport->lld_data;
+ int i;
+
+ for (i = 0; i < SRP_CMD_SQ_SIZE; ++i) {
+ struct srp_request *req = &target->req_ring[i];
+ srp_finish_req(target, req, DID_TRANSPORT_FAILFAST << 16);
+ }
+}
+
static int srp_reconnect_target(struct srp_target_port *target)
{
struct Scsi_Host *shost = target->scsi_host;
@@ -725,8 +737,7 @@ static int srp_reconnect_target(struct srp_target_port *target)
for (i = 0; i < SRP_CMD_SQ_SIZE; ++i) {
struct srp_request *req = &target->req_ring[i];
- if (req->scmnd)
- srp_reset_req(target, req);
+ srp_finish_req(target, req, DID_RESET << 16);
}
INIT_LIST_HEAD(&target->free_tx);
@@ -1784,7 +1795,7 @@ static int srp_reset_device(struct scsi_cmnd *scmnd)
for (i = 0; i < SRP_CMD_SQ_SIZE; ++i) {
struct srp_request *req = &target->req_ring[i];
if (req->scmnd && req->scmnd->device == scmnd->device)
- srp_reset_req(target, req);
+ srp_finish_req(target, req, DID_RESET << 16);
}
return SUCCESS;
@@ -2616,6 +2627,7 @@ static void srp_remove_one(struct ib_device *device)
static struct srp_function_template ib_srp_transport_functions = {
.rport_delete = srp_rport_delete,
+ .terminate_rport_io = srp_terminate_io,
};
static int __init srp_init_module(void)
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-08-20 12:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 12:41 [PATCH 0/8] IB SRP initiator patches for kernel 3.12 Bart Van Assche
[not found] ` <521363EA.8080906-HInyCGIudOg@public.gmane.org>
2013-08-20 12:43 ` [PATCH 1/8] IB/srp: Keep rport as long as the IB transport layer Bart Van Assche
2013-08-20 12:44 ` [PATCH 2/8] scsi_transport_srp: Add transport layer error handling Bart Van Assche
2013-08-20 12:45 ` Bart Van Assche [this message]
2013-08-20 12:46 ` [PATCH 4/8] IB/srp: Use SRP transport layer error recovery Bart Van Assche
2013-08-20 12:46 ` [PATCH 5/8] IB/srp: Start timers if a transport layer error occurs Bart Van Assche
2013-08-20 12:47 ` [PATCH 6/8] IB/srp: Make transport layer retry count configurable Bart Van Assche
2013-08-20 12:48 ` [PATCH 7/8] IB/srp: Introduce srp_alloc_req_data() Bart Van Assche
2013-08-20 12:50 ` [PATCH 8/8] IB/srp: Make queue size configurable Bart Van Assche
[not found] ` <52136609.3090406-HInyCGIudOg@public.gmane.org>
2013-08-20 15:34 ` Sagi Grimberg
[not found] ` <52138C6E.6080201-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-08-20 15:55 ` Bart Van Assche
[not found] ` <5213917B.3020403-HInyCGIudOg@public.gmane.org>
2013-08-20 17:43 ` David Dillow
[not found] ` <1377020595.22321.6.camel-zHLflQxYYDO4Hhoo1DtQwJ9G+ZOsUmrO@public.gmane.org>
2013-08-21 7:19 ` Sagi Grimberg
2013-09-10 3:01 ` David Dillow
[not found] ` <1378782080.3794.6.camel-VK19RVc5TWXUd6DVheFtbw@public.gmane.org>
2013-09-10 17:44 ` Bart Van Assche
[not found] ` <522F5A81.8040101-HInyCGIudOg@public.gmane.org>
2013-09-11 22:16 ` David Dillow
[not found] ` <1378937796.6649.5.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2013-09-12 16:16 ` Jack Wang
[not found] ` <5231E8CE.5060105-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-12 16:30 ` Bart Van Assche
[not found] ` <5231EC1A.7030902-HInyCGIudOg@public.gmane.org>
2013-09-13 8:06 ` Jack Wang
[not found] ` <5232C76B.4010704-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-13 8:40 ` Bart Van Assche
[not found] ` <5232CF86.20507-HInyCGIudOg@public.gmane.org>
2013-09-13 9:24 ` Bart Van Assche
[not found] ` <5232D9BC.7090808-HInyCGIudOg@public.gmane.org>
2013-09-13 12:25 ` Jack Wang
[not found] ` <5233043F.5020804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-13 13:33 ` Bart Van Assche
[not found] ` <52331444.8070007-HInyCGIudOg@public.gmane.org>
2013-09-13 13:51 ` Jack Wang
[not found] ` <52331854.9010607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-13 14:03 ` Bart Van Assche
[not found] ` <52331B47.9070202-HInyCGIudOg@public.gmane.org>
2013-09-13 14:15 ` Jack Wang
[not found] ` <52331E01.3060005-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-13 14:31 ` Jack Wang
2013-09-13 14:31 ` Bart Van Assche
2013-09-16 14:25 ` Bart Van Assche
[not found] ` <523714D8.3020104-HInyCGIudOg@public.gmane.org>
2013-09-16 14:28 ` David Dillow
2013-09-10 2:53 ` [PATCH 0/8] IB SRP initiator patches for kernel 3.12 David Dillow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521364D7.3040007@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
--cc=vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).