Re: [PATCH 8/8] IB/srp: Make queue size configurable

[Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>]

On 09/10/13 05:01, David Dillow wrote:
> On Tue, 2013-08-20 at 14:50 +0200, Bart Van Assche wrote:
>> @@ -2227,6 +2270,7 @@ static const match_table_t srp_opt_tokens = {
>>          { SRP_OPT_SG_TABLESIZE,         "sg_tablesize=%u"       },
>>          { SRP_OPT_COMP_VECTOR,          "comp_vector=%u"        },
>>          { SRP_OPT_TL_RETRY_COUNT,       "tl_retry_count=%u"     },
>> +       { SRP_OPT_CAN_QUEUE,            "can_queue=%d"          },
>
> I'm pretty much OK with the patch, but since we're stuck with it going
> forward, I'd like to have a better externally visible name here --
> queue_depth? max_queue? queue_size?
>
> Otherwise,
> Acked-by: David Dillow <dillowda-1Heg1YXhbW8@public.gmane.org>

Hello Dave,

If this name was not yet in use in any interface that is visible in user 
space, I would agree that we should come up with a better name. However, 
the SCSI mid-layer already uses that name today to export the queue 
size. To me this looks like a good reason to use the name "can_queue" ? 
An example:

$ cat /sys/class/scsi_host/host93/can_queue
62

See also the shost_rd_attr(can_queue, "%hd\n") statement in 
drivers/scsi/scsi_sysfs.c.

Bart.


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html