From: Jack Wang <xjtuwjp-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org>
Cc: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
David Dillow <dad-1Heg1YXhbW8@public.gmane.org>,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Sebastian Riemer
<sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Konrad Grzybowski <konradg-XLFqaoR9dsI@public.gmane.org>
Subject: Re: [PATCH 8/8] IB/srp: Make queue size configurable
Date: Thu, 12 Sep 2013 18:16:14 +0200 [thread overview]
Message-ID: <5231E8CE.5060105@gmail.com> (raw)
In-Reply-To: <1378937796.6649.5.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
On 09/12/2013 12:16 AM, David Dillow wrote:
> On Tue, 2013-09-10 at 19:44 +0200, Bart Van Assche wrote:
>> If this name was not yet in use in any interface that is visible in user
>> space, I would agree that we should come up with a better name. However,
>> the SCSI mid-layer already uses that name today to export the queue
>> size. To me this looks like a good reason to use the name "can_queue" ?
>> An example:
>>
>> $ cat /sys/class/scsi_host/host93/can_queue
>> 62
>
> Yes, I know it has been used before, but I'm torn between not furthering
> a bad naming choice and consistency. Foolish consistency and all that...
>
> I really don't like "can_queue", but I'll not complain if Roland decides
> to take it as-is.
>
> --
Hi,
What the allow range for this queue size?
Default cmd_per_lun and can_queue with same value makes no sense to me.
Could we bump can_queue to bigger value like 512?
Best
Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-12 16:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 12:41 [PATCH 0/8] IB SRP initiator patches for kernel 3.12 Bart Van Assche
[not found] ` <521363EA.8080906-HInyCGIudOg@public.gmane.org>
2013-08-20 12:43 ` [PATCH 1/8] IB/srp: Keep rport as long as the IB transport layer Bart Van Assche
2013-08-20 12:44 ` [PATCH 2/8] scsi_transport_srp: Add transport layer error handling Bart Van Assche
2013-08-20 12:45 ` [PATCH 3/8] IB/srp: Add srp_terminate_io() Bart Van Assche
2013-08-20 12:46 ` [PATCH 4/8] IB/srp: Use SRP transport layer error recovery Bart Van Assche
2013-08-20 12:46 ` [PATCH 5/8] IB/srp: Start timers if a transport layer error occurs Bart Van Assche
2013-08-20 12:47 ` [PATCH 6/8] IB/srp: Make transport layer retry count configurable Bart Van Assche
2013-08-20 12:48 ` [PATCH 7/8] IB/srp: Introduce srp_alloc_req_data() Bart Van Assche
2013-08-20 12:50 ` [PATCH 8/8] IB/srp: Make queue size configurable Bart Van Assche
[not found] ` <52136609.3090406-HInyCGIudOg@public.gmane.org>
2013-08-20 15:34 ` Sagi Grimberg
[not found] ` <52138C6E.6080201-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-08-20 15:55 ` Bart Van Assche
[not found] ` <5213917B.3020403-HInyCGIudOg@public.gmane.org>
2013-08-20 17:43 ` David Dillow
[not found] ` <1377020595.22321.6.camel-zHLflQxYYDO4Hhoo1DtQwJ9G+ZOsUmrO@public.gmane.org>
2013-08-21 7:19 ` Sagi Grimberg
2013-09-10 3:01 ` David Dillow
[not found] ` <1378782080.3794.6.camel-VK19RVc5TWXUd6DVheFtbw@public.gmane.org>
2013-09-10 17:44 ` Bart Van Assche
[not found] ` <522F5A81.8040101-HInyCGIudOg@public.gmane.org>
2013-09-11 22:16 ` David Dillow
[not found] ` <1378937796.6649.5.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2013-09-12 16:16 ` Jack Wang [this message]
[not found] ` <5231E8CE.5060105-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-12 16:30 ` Bart Van Assche
[not found] ` <5231EC1A.7030902-HInyCGIudOg@public.gmane.org>
2013-09-13 8:06 ` Jack Wang
[not found] ` <5232C76B.4010704-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-13 8:40 ` Bart Van Assche
[not found] ` <5232CF86.20507-HInyCGIudOg@public.gmane.org>
2013-09-13 9:24 ` Bart Van Assche
[not found] ` <5232D9BC.7090808-HInyCGIudOg@public.gmane.org>
2013-09-13 12:25 ` Jack Wang
[not found] ` <5233043F.5020804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-13 13:33 ` Bart Van Assche
[not found] ` <52331444.8070007-HInyCGIudOg@public.gmane.org>
2013-09-13 13:51 ` Jack Wang
[not found] ` <52331854.9010607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-13 14:03 ` Bart Van Assche
[not found] ` <52331B47.9070202-HInyCGIudOg@public.gmane.org>
2013-09-13 14:15 ` Jack Wang
[not found] ` <52331E01.3060005-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-13 14:31 ` Jack Wang
2013-09-13 14:31 ` Bart Van Assche
2013-09-16 14:25 ` Bart Van Assche
[not found] ` <523714D8.3020104-HInyCGIudOg@public.gmane.org>
2013-09-16 14:28 ` David Dillow
2013-09-10 2:53 ` [PATCH 0/8] IB SRP initiator patches for kernel 3.12 David Dillow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5231E8CE.5060105@gmail.com \
--to=xjtuwjp-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=dad-1Heg1YXhbW8@public.gmane.org \
--cc=dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org \
--cc=konradg-XLFqaoR9dsI@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
--cc=vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).