From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata() Date: Wed, 5 Apr 2017 17:04:35 +0200 Message-ID: <523b0864-e655-ed1f-8fe5-5995e0b0bde1@users.sourceforge.net> References: <20170405143242.GB5006@yuval-lap> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170405143242.GB5006@yuval-lap> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Yuval Shaia Cc: linux-rdma@vger.kernel.org, Doug Ledford , Hal Rosenstock , Mike Marciniszyn , Sean Hefty , LKML , kernel-janitors@vger.kernel.org List-Id: linux-rdma@vger.kernel.org >> @@ -270,13 +268,14 @@ int qib_init_pportdata(struct qib_pportdata *ppd, struct qib_devdata *dd, >> if (!ppd->congestion_entries) >> goto bail_1; >> >> - size = sizeof(struct cc_table_shadow); >> - ppd->ccti_entries_shadow = kzalloc(size, GFP_KERNEL); >> + ppd->ccti_entries_shadow = kzalloc(sizeof(*ppd->ccti_entries_shadow), >> + GFP_KERNEL); >> if (!ppd->ccti_entries_shadow) >> goto bail_2; >> >> - size = sizeof(struct ib_cc_congestion_setting_attr); >> - ppd->congestion_entries_shadow = kzalloc(size, GFP_KERNEL); >> + ppd->congestion_entries_shadow = kzalloc(sizeof(*ppd >> + ->congestion_entries_shadow), >> + GFP_KERNEL); > > Not related to this patch but is related to your patch-set - can you check > the array allocations in lines 264 and 268? Do you refer to source code places here which are affected by the update step "[PATCH 4/5] IB/qib: Use kcalloc() in qib_init_pportdata()"? > Besides that: > Reviewed-by: Yuval Shaia Do you find the proposed change for the shown data types really acceptable in these function calls? Regards, Markus