public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Oren Duer <oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH RFC 2/9] IB/core: Introduce Signature Verbs API
Date: Mon, 21 Oct 2013 19:12:50 +0300	[thread overview]
Message-ID: <52655282.1000505@mellanox.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237388CEA91E-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>

On 10/21/2013 5:34 PM, Hefty, Sean wrote:
>> The signature handover operation is binding all the necessary
>> information for the HCA together: where is the data (data_mr), where is
>> the protection information (prot_mr), what are the signature properties
>> (sig_attrs).
>> Once this step is taken (WR is posted), a single MR (sig_mr) describes
>> the signature handover operation and can be used to perform RDMA under
>> signature presence.
>> Once the HCA will perform RDMA over this MR, it will take into account
>> the signature context of the transaction and will follow the signature
>> attributes configured.
> It seems like this changes loses the ability to use an SGL.

I don't think so,
Signature MR simply describes a "signature associated" memory region 
i.e. it is a memory region that
also defines some signature operation offload aside from normal RDMA 
(for example validate & strip).
SGL are used to publish several rkeys for the server/target/peer to 
perform RDMA on each.
In this case the user previously registered each MR which he wishes it's 
peer to RDMA over.
Same story here, if user has several signature associated MRs, where he 
wish his peer to RDMA over (in a protected manner),
he can use these rkeys to construct SGL.

>    Why are the signature properties separate from the protection information?

Well,
Protection information is the actual protection block guards of the data 
(i.e. CRCs, XORs, DIFs etc..), while the signature properties
structure is the descriptor telling the HCA how to 
treat/validate/generate the protection information.

Note that signature support requires the HCA to be able to support 
INSERT operations.
This means that there is no protection information and the HCA is asked 
to generate it and add it to the data stream
(which may be incoming or outgoing...),

Hope this helps.

Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-10-21 16:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 15:38 [PATCH RFC 0/9] Introduce Signature feature Sagi Grimberg
     [not found] ` <1381851510-17290-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-15 15:38   ` [PATCH RFC 1/9] IB/core: Introduce indirect and protected memory regions Sagi Grimberg
     [not found]     ` <1381851510-17290-2-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-17 22:43       ` Hefty, Sean
     [not found]         ` <1828884A29C6694DAF28B7E6B8A8237388CE2BE0-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-10-20 13:05           ` Sagi Grimberg
     [not found]         ` <5263CC09.6030103@mellanox.com>
     [not found]           ` <5263CC09.6030103-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-21 14:39             ` Hefty, Sean
2013-10-15 15:38   ` [PATCH RFC 2/9] IB/core: Introduce Signature Verbs API Sagi Grimberg
     [not found]     ` <1381851510-17290-3-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-17 22:51       ` Hefty, Sean
     [not found]         ` <1828884A29C6694DAF28B7E6B8A8237388CE2BFF-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-10-20 12:55           ` Sagi Grimberg
     [not found]             ` <5263D2DE.8010500-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-21 14:34               ` Hefty, Sean
     [not found]                 ` <1828884A29C6694DAF28B7E6B8A8237388CEA91E-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-10-21 16:12                   ` Sagi Grimberg [this message]
     [not found]                     ` <52655282.1000505-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-22 16:41                       ` Hefty, Sean
     [not found]                         ` <1828884A29C6694DAF28B7E6B8A8237388CEE1C7-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-10-22 17:46                           ` Sagi Grimberg
     [not found]                             ` <5266BA11.6090300-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-22 18:20                               ` Hefty, Sean
     [not found]                                 ` <1828884A29C6694DAF28B7E6B8A8237388CEE286-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-10-23 10:42                                   ` Sagi Grimberg
2013-10-15 15:38   ` [PATCH RFC 3/9] IB/mlx5, mlx5_core: Support for create_mr and destroy_mr Sagi Grimberg
2013-10-15 15:38   ` [PATCH RFC 4/9] IB/mlx5: Initialize mlx5_ib_qp signature related Sagi Grimberg
2013-10-15 15:38   ` [PATCH RFC 5/9] IB/mlx5: Break wqe handling to begin & finish routines Sagi Grimberg
2013-10-15 15:38   ` [PATCH RFC 6/9] IB/mlx5: remove MTT access mode from umr flags helper function Sagi Grimberg
2013-10-15 15:38   ` [PATCH RFC 7/9] IB/mlx5: Support IB_WR_REG_SIG_MR Sagi Grimberg
2013-10-15 15:38   ` [PATCH RFC 8/9] IB/mlx5: Collect signature error completion Sagi Grimberg
2013-10-15 15:38   ` [PATCH RFC 9/9] IB/mlx5: Publish support in signature feature Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52655282.1000505@mellanox.com \
    --to=sagig-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox