From: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: "Hefty,
Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH RFC v1 01/10] IB/core: Introduce protected memory regions
Date: Tue, 29 Oct 2013 10:15:17 +0200 [thread overview]
Message-ID: <526F6E95.5080100@mellanox.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237388CF1CDD-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 10/28/2013 11:22 PM, Hefty, Sean wrote:
>> +enum ib_mr_create_flags {
>> + IB_MR_SIGNATURE_EN = 1,
>> +};
>> +
>> +/**
>> + * ib_mr_init_attr - Memory region init attributes passed to routine
>> + * ib_create_mr.
>> + * @max_reg_descriptors: max number of registration units that
>> + * may be used with UMR work requests.
>> + * @flags: MR creation flags bit mask.
>> + */
>> +struct ib_mr_init_attr {
>> + int max_reg_descriptors;
>> + enum ib_mr_create_flags flags;
> Assuming that flags will be a bitwise OR of values, they should be an int, not an enum.
Right, will fix. The same applies to signature caps in ib_device.
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-29 8:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 14:26 [PATCH RFC v1 00/10] Introduce Signature feature Sagi Grimberg
[not found] ` <1382970376-13776-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-28 14:26 ` [PATCH RFC v1 01/10] IB/core: Introduce protected memory regions Sagi Grimberg
[not found] ` <1382970376-13776-2-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-28 21:22 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237388CF1CDD-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-10-29 7:25 ` Or Gerlitz
[not found] ` <526F62DA.4050304-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-29 19:34 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237388CF25C5-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-10-29 20:20 ` Or Gerlitz
2013-10-29 8:15 ` Sagi Grimberg [this message]
2013-10-28 14:26 ` [PATCH RFC v1 02/10] IB/core: Introduce Signature Verbs API Sagi Grimberg
2013-10-28 14:26 ` [PATCH RFC v1 03/10] IB/mlx5, mlx5_core: Support for create_mr and destroy_mr Sagi Grimberg
2013-10-28 14:26 ` [PATCH RFC v1 04/10] IB/mlx5: Initialize mlx5_ib_qp signature related Sagi Grimberg
2013-10-28 14:26 ` [PATCH RFC v1 05/10] IB/mlx5: Break wqe handling to begin & finish routines Sagi Grimberg
2013-10-28 14:26 ` [PATCH RFC v1 06/10] IB/mlx5: remove MTT access mode from umr flags helper function Sagi Grimberg
2013-10-28 14:26 ` [PATCH RFC v1 07/10] IB/mlx5: Keep mlx5 MRs in a radix tree under device Sagi Grimberg
2013-10-28 14:26 ` [PATCH RFC v1 08/10] IB/mlx5: Support IB_WR_REG_SIG_MR Sagi Grimberg
2013-10-28 14:26 ` [PATCH RFC v1 09/10] IB/mlx5: Collect signature error completion Sagi Grimberg
2013-10-28 14:26 ` [PATCH RFC v1 10/10] IB/mlx5: Publish support in signature feature Sagi Grimberg
2013-10-30 10:29 ` [PATCH RFC v1 00/10] Introduce Signature feature Or Gerlitz
[not found] ` <5270DF90.8000802-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-30 15:20 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237388CF28A5-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-10-30 15:55 ` Or Gerlitz
[not found] ` <52712BE4.3060103-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-31 9:29 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526F6E95.5080100@mellanox.com \
--to=sagig-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox