Re: failure to get gid with rdma_bind_addr with >= 3.10 kernels

[Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

On 11/11/2013 20:46, Hefty, Sean wrote:
> Yes - something like this patch should help, but I don't think this is the correct behavior when the IP address is 'any' addresss.
>
> Retrieve SGID after calling rdma_bind_addr
>
> From: Sean Hefty<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> A change was made to rdma_bind_addr when AF_IB is enabled
> to only retrieve the resulting bound address.  Previously,
> rdma_bind_addr would retrieve the corresponding SGID as
> well.  This breaks some apps which were checking the
> SGID after binding to an IP address.  Revert to the
> previous behavior of also retrieving the SGID after
> calling rdma_bind_addr.
> ---
>   src/cma.c |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/src/cma.c b/src/cma.c
> index 4f41879..0cf4203 100644
> --- a/src/cma.c
> +++ b/src/cma.c
> @@ -753,7 +753,10 @@ static int rdma_bind_addr2(struct rdma_cm_id *id, struct sockaddr *addr,
>   	if (ret != sizeof cmd)
>   		return (ret >= 0) ? ERR(ENODATA) : -1;
>   
> -	return ucma_query_addr(id);
> +	ret = ucma_query_addr(id);
> +	if (!ret)
> +		ret = ucma_query_gid(id);
> +	return ret;
>   }
>   
>   int rdma_bind_addr(struct rdma_cm_id *id, struct sockaddr *addr)

Sean, how do we continue here? the patch worked for Christoph, so are 
going to merge it into librdmacm or it needs more work?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html