From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Somnath Kotur
<Somnath.Kotur-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org>,
Devesh Sharma
<Devesh.Sharma-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org>,
Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
monis <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
matanb <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Tzahi Oved <tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Moni Shoua <monis-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH V5 7/8] IB/uverbs: Resolve Ethernet L2 addresses when modifying QP
Date: Wed, 20 Nov 2013 12:08:11 +0200 [thread overview]
Message-ID: <528C8A0B.3030700@mellanox.com> (raw)
In-Reply-To: <dad4986f-4b34-47dc-b6bb-b4882ad1405a-3RiH6ntJJkOPfaB/Gd0HpljyZtpTMMwT@public.gmane.org>
On 20/11/2013 09:15, Somnath Kotur wrote:
>> However, in the approach to move address resolution to core verbs i.e.
>> >ib_modify_qp() and ib_create_ah(), vendor driver will have freedom to
>> >resolve l2 addresses in its own way.
> This I am not sure if it's a good idea for each vendor driver to implement L2 address resolution in it's own way? Not sure if that was the intent behind Roland's statement ?
I agree with Somnath, I don't see the point in putting L3 --> L2 address
resolution within vendor drivers. This will create huge code
duplication, and more problems. Again, with the proposed patches all
kernel ULPs that are applicable to RoCE are covered and hence there's no
address resolution for kernel session. To comply with non-modified user
space applications/libraries V5 added a code to do address resolution
and Roland just pointed out it may makes more sense to put that small
code piece in the core verbs modify_qp function and not in the uverbs call.
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-20 10:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 22:29 [PATCH V5 0/8] IP based RoCE GID Addressing Or Gerlitz
[not found] ` <1384381792-2023-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-11-13 22:29 ` [PATCH V5 1/8] IB/core: Ethernet L2 attributes in verbs/cm structures Or Gerlitz
2013-11-13 22:29 ` [PATCH V5 2/8] IB/CMA: IBoE (RoCE) IP based GID addressing Or Gerlitz
2013-11-13 22:29 ` [PATCH V5 3/8] IB/mlx4: Use IBoE (RoCE) IP based GIDs in the port GID table Or Gerlitz
2013-11-13 22:29 ` [PATCH V5 4/8] IB/mlx4: Handle Ethernet L2 parameters for IP based GID addressing Or Gerlitz
2013-11-13 22:29 ` [PATCH V5 5/8] IB/ocrdma: " Or Gerlitz
2013-11-13 22:29 ` [PATCH V5 6/8] IB/ocrdma: Populate GID table with IP based gids Or Gerlitz
2013-11-13 22:29 ` [PATCH V5 7/8] IB/uverbs: Resolve Ethernet L2 addresses when modifying QP Or Gerlitz
[not found] ` <1384381792-2023-8-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-11-19 18:08 ` Roland Dreier
[not found] ` <CAG4TOxOUFfPMU+q1yKy6S7v3QiLVgMQwxNC-_vw-7UeUb7LoBg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-19 20:48 ` Or Gerlitz
[not found] ` <CAJZOPZ+5UJCAObzFjK5w=bnnSjRM102vR5Ft1nd4nO48Lr2HOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-20 4:09 ` Devesh Sharma
[not found] ` <EE7902D3F51F404C82415C4803930ACD3FD8348A-DWYeeINJQrxExQ8dmkPuX0M9+F4ksjoh@public.gmane.org>
2013-11-20 7:15 ` Somnath Kotur
[not found] ` <dad4986f-4b34-47dc-b6bb-b4882ad1405a-3RiH6ntJJkOPfaB/Gd0HpljyZtpTMMwT@public.gmane.org>
2013-11-20 10:07 ` Or Gerlitz
2013-11-20 10:08 ` Or Gerlitz [this message]
[not found] ` <528C8A0B.3030700-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-11-20 12:22 ` Devesh Sharma
2013-12-11 17:45 ` Or Gerlitz
2013-11-13 22:29 ` [PATCH V5 8/8] mlx4_en: Avoid setting netdevice dev_id to port number Or Gerlitz
2013-11-16 19:52 ` [PATCH V5 0/8] IP based RoCE GID Addressing Or Gerlitz
2013-11-22 10:29 ` Somnath Kotur
-- strict thread matches above, loose matches on Subject: below --
2013-12-11 17:59 [PATCH V5 7/8] IB/uverbs: Resolve Ethernet L2 addresses when modifying QP Roland Dreier
[not found] ` <CAG4TOxMgHuC=rzB+8stotaeKqwxipz06s_B2zogMMqNn3ZWTOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-11 20:41 ` Or Gerlitz
[not found] ` <CAJZOPZ+d9xsCQ4nKq5iEaR6tenqvG7spBXKiJBcHjL22c3ePRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-12 5:49 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528C8A0B.3030700@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=Devesh.Sharma-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org \
--cc=Somnath.Kotur-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=monis-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox