* [PATCH] drivers: infiniband: Mark function _c4iw_write_mem_dma() as static in mem.c
@ 2013-12-14 13:12 Rashika Kheria
2013-12-14 16:01 ` Steve Wise
2013-12-14 20:24 ` Josh Triplett
0 siblings, 2 replies; 3+ messages in thread
From: Rashika Kheria @ 2013-12-14 13:12 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Steve Wise, Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, josh-iaAMLnmF4UmaiuxdJuQwMA
This patch marks the function _c4iw_write_mem_dma() as static in
hw/cxgb4/mem.c because it is not used outside this file.
Thus, it also eliminates the following warning in hw/cxgb4/mem.c:
drivers/infiniband/hw/cxgb4/mem.c:176:5: warning: no previous prototype for ‘_c4iw_write_mem_dma’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/infiniband/hw/cxgb4/mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c
index 4cb8eb2..84e4500 100644
--- a/drivers/infiniband/hw/cxgb4/mem.c
+++ b/drivers/infiniband/hw/cxgb4/mem.c
@@ -173,7 +173,7 @@ static int _c4iw_write_mem_inline(struct c4iw_rdev *rdev, u32 addr, u32 len,
return ret;
}
-int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len, void *data)
+static int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len, void *data)
{
u32 remain = len;
u32 dmalen;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: infiniband: Mark function _c4iw_write_mem_dma() as static in mem.c
2013-12-14 13:12 [PATCH] drivers: infiniband: Mark function _c4iw_write_mem_dma() as static in mem.c Rashika Kheria
@ 2013-12-14 16:01 ` Steve Wise
2013-12-14 20:24 ` Josh Triplett
1 sibling, 0 replies; 3+ messages in thread
From: Steve Wise @ 2013-12-14 16:01 UTC (permalink / raw)
To: Rashika Kheria, linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, josh-iaAMLnmF4UmaiuxdJuQwMA
Acked-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: infiniband: Mark function _c4iw_write_mem_dma() as static in mem.c
2013-12-14 13:12 [PATCH] drivers: infiniband: Mark function _c4iw_write_mem_dma() as static in mem.c Rashika Kheria
2013-12-14 16:01 ` Steve Wise
@ 2013-12-14 20:24 ` Josh Triplett
1 sibling, 0 replies; 3+ messages in thread
From: Josh Triplett @ 2013-12-14 20:24 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Steve Wise, Roland Dreier,
Sean Hefty, Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Sat, Dec 14, 2013 at 06:42:14PM +0530, Rashika Kheria wrote:
> This patch marks the function _c4iw_write_mem_dma() as static in
> hw/cxgb4/mem.c because it is not used outside this file.
>
> Thus, it also eliminates the following warning in hw/cxgb4/mem.c:
> drivers/infiniband/hw/cxgb4/mem.c:176:5: warning: no previous prototype for ‘_c4iw_write_mem_dma’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Reviewed-by: Josh Triplett <josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
> drivers/infiniband/hw/cxgb4/mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c
> index 4cb8eb2..84e4500 100644
> --- a/drivers/infiniband/hw/cxgb4/mem.c
> +++ b/drivers/infiniband/hw/cxgb4/mem.c
> @@ -173,7 +173,7 @@ static int _c4iw_write_mem_inline(struct c4iw_rdev *rdev, u32 addr, u32 len,
> return ret;
> }
>
> -int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len, void *data)
> +static int _c4iw_write_mem_dma(struct c4iw_rdev *rdev, u32 addr, u32 len, void *data)
> {
> u32 remain = len;
> u32 dmalen;
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-14 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14 13:12 [PATCH] drivers: infiniband: Mark function _c4iw_write_mem_dma() as static in mem.c Rashika Kheria
2013-12-14 16:01 ` Steve Wise
2013-12-14 20:24 ` Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox