public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Ilya Nelkenbaum <ilyan-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Hal Rosenstock
	<hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	Sasha Kotchubievsky
	<sashakot-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH v2] ssa_smdb.[c h]: remove 'osm_header.h' dependency from 'ssa_smdb.h'
Date: Mon, 16 Dec 2013 15:30:29 +0200	[thread overview]
Message-ID: <52AF0075.3070709@dev.mellanox.co.il> (raw)


Signed-off-by: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
Changes since version 1:
 - all method declarations were removed from 'ssa_smdb.h'
 - argument types were changed back from 'void*' to
   specific types

 include/infiniband/ssa_smdb.h |   26 --------------------------
 plugin/src/ssa_extract.c      |   16 ++++++++++++++++
 plugin/src/ssa_smdb.c         |    1 +
 3 files changed, 17 insertions(+), 26 deletions(-)

diff --git a/include/infiniband/ssa_smdb.h b/include/infiniband/ssa_smdb.h
index 66fae67..016c99f 100644
--- a/include/infiniband/ssa_smdb.h
+++ b/include/infiniband/ssa_smdb.h
@@ -34,7 +34,6 @@
 #ifndef _SSA_SMDB_H_
 #define _SSA_SMDB_H_
 
-#include <infiniband/osm_headers.h>
 #include <infiniband/ssa_db.h>
 #include <infiniband/umad_sm.h>
 
@@ -204,30 +203,5 @@ struct ep_lft_block_tbl_rec {
 struct ssa_db *ssa_db_smdb_init(uint64_t data_rec_cnt[SSA_TABLE_ID_MAX]);
 
 void ssa_db_smdb_destroy(struct ssa_db * p_smdb);
-
-/**********************SUBNET OPTS records*******************************/
-void ep_subnet_opts_tbl_rec_init(osm_subn_t *p_subn,
-				 struct ep_subnet_opts_tbl_rec * p_rec);
-
-/**********************GUID to LID records*******************************/
-void ep_guid_to_lid_tbl_rec_init(osm_port_t *p_port,
-				 struct ep_guid_to_lid_tbl_rec * p_rec);
-
-/**********************NODE records**************************************/
-void ep_node_tbl_rec_init(osm_node_t *p_node, struct ep_node_tbl_rec * p_rec);
-
-/**********************LINK records**************************************/
-void ep_link_tbl_rec_init(osm_physp_t *p_physp, struct ep_link_tbl_rec * p_rec);
-
-/**********************PORT records**************************************/
-void ep_port_tbl_rec_init(osm_physp_t *p_physp, struct ep_port_tbl_rec * p_rec);
-
-/********************** LFT Block records*******************************/
-void ep_lft_block_tbl_rec_init(osm_switch_t *p_sw, uint16_t lid, uint16_t block,
-			       struct ep_lft_block_tbl_rec * p_rec);
-
-/********************** LFT Top records*********************************/
-void ep_lft_top_tbl_rec_init(uint16_t lid, uint16_t lft_top,
-			     struct ep_lft_top_tbl_rec *p_rec);
 END_C_DECLS
 #endif				/* _SSA_SMDB_H_ */
diff --git a/plugin/src/ssa_extract.c b/plugin/src/ssa_extract.c
index c8847eb..0587230 100644
--- a/plugin/src/ssa_extract.c
+++ b/plugin/src/ssa_extract.c
@@ -54,6 +54,22 @@ extern struct ssa_database *ssa_db;
 extern int first;
 extern int smdb_deltas;
 
+extern void ep_subnet_opts_tbl_rec_init(osm_subn_t * p_subn,
+					struct ep_subnet_opts_tbl_rec * p_rec);
+extern void ep_guid_to_lid_tbl_rec_init(osm_port_t * p_port,
+					struct ep_guid_to_lid_tbl_rec * p_rec);
+extern void ep_node_tbl_rec_init(osm_node_t * p_node,
+				 struct ep_node_tbl_rec * p_rec);
+extern void ep_link_tbl_rec_init(osm_physp_t * p_physp,
+				 struct ep_link_tbl_rec * p_rec);
+extern void ep_port_tbl_rec_init(osm_physp_t * p_physp,
+				 struct ep_port_tbl_rec * p_rec);
+extern void ep_lft_block_tbl_rec_init(osm_switch_t * p_sw, uint16_t lid,
+				      uint16_t block,
+				      struct ep_lft_block_tbl_rec * p_rec);
+extern void ep_lft_top_tbl_rec_init(uint16_t lid, uint16_t lft_top,
+				    struct ep_lft_top_tbl_rec * p_rec);
+
 /** =========================================================================
  */
 struct ssa_db_extract *ssa_db_extract(osm_opensm_t *p_osm)
diff --git a/plugin/src/ssa_smdb.c b/plugin/src/ssa_smdb.c
index ed0a53e..a6e75a1 100644
--- a/plugin/src/ssa_smdb.c
+++ b/plugin/src/ssa_smdb.c
@@ -32,6 +32,7 @@
  */
 
 #include <infiniband/ssa_smdb.h>
+#include <infiniband/osm_headers.h>
 #include <asm/byteorder.h>
 
 static const struct db_table_def def_tbl[] = {
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2013-12-16 13:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 13:30 Ilya Nelkenbaum [this message]
     [not found] ` <52AF0075.3070709-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-12-16 13:37   ` [PATCH v2] ssa_smdb.[c h]: remove 'osm_header.h' dependency from 'ssa_smdb.h' Hal Rosenstock
2013-12-16 13:44   ` Ilya Nelkenbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AF0075.3070709@dev.mellanox.co.il \
    --to=ilyan-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sashakot-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox