Re: [PATCH 09/11] IB/isert: Accept RDMA_WRITE completions

[Sagi Grimberg <sagig@dev.mellanox.co.il>]

On 1/11/2014 11:14 PM, Or Gerlitz wrote:
> On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg <sagig@mellanox.com> wrote:
>> In case of protected transactions, we will need to check the
>> protection status of the transaction before sending SCSI response.
>> So be ready for RDMA_WRITE completions. currently we don't ask
>> for these completions, but for T10-PI we will.
>> @@ -1721,9 +1735,9 @@ __isert_send_completion(struct iser_tx_desc *tx_desc,
>>                                            isert_conn, ib_dev);
>>                  break;
>>          case ISER_IB_RDMA_WRITE:
>> -               pr_err("isert_send_completion: Got ISER_IB_RDMA_WRITE\n");
>> -               dump_stack();
>> -               break;
>> +               pr_debug("isert_send_completion: Got ISER_IB_RDMA_WRITE\n");
>> +               atomic_dec(&isert_conn->post_send_buf_count);
>> +               isert_completion_rdma_write(tx_desc, isert_cmd);
> are we doing fall through here? why?

Ohhhh, somehow i missed it in squash... Will fix, Thanks!

>>          case ISER_IB_RDMA_READ:
>>                  pr_debug("isert_send_completion: Got ISER_IB_RDMA_READ:\n");
>