Re: [PATCH -next] IB/cm: Fix missing unlock on error in cm_init_qp_rtr_attr()

[Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

On 16/1/2014 10:28 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>
> Add the missing unlock before return from function cm_init_qp_rtr_attr()
> in the error handling case.
>
> Fixes: dd5f03beb4f7 ('IB/core: Ethernet L2 attributes in verbs/cm structures')
> Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
> ---
>   drivers/infiniband/core/cm.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index c6d543c..0601b9d 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -3526,8 +3526,10 @@ static int cm_init_qp_rtr_attr(struct cm_id_private *cm_id_priv,
>   		*qp_attr_mask = IB_QP_STATE | IB_QP_AV | IB_QP_PATH_MTU |
>   				IB_QP_DEST_QPN | IB_QP_RQ_PSN;
>   		qp_attr->ah_attr = cm_id_priv->av.ah_attr;
> -		if (!cm_id_priv->av.valid)
> +		if (!cm_id_priv->av.valid) {

Hi,

Thanks for the fix.

> +			spin_unlock_irqrestore(&cm_id_priv->lock, flags);
>   			return -EINVAL;
> +		}

Another option is to go with "goto style" error-handling. This could 
have some future benefit if this code will get more complicated 
(introducing more error flows).


>   		if (cm_id_priv->av.ah_attr.vlan_id != 0xffff) {
>   			qp_attr->vlan_id = cm_id_priv->av.ah_attr.vlan_id;
>   			*qp_attr_mask |= IB_QP_VID;
>

Regards,
Matan

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html