From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Sagi Grimberg <sagig@mellanox.com>, nab@linux-iscsi.org
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/mlx5: Fix signature rule constants according to FW specifications
Date: Sun, 19 Jan 2014 15:07:10 +0200 [thread overview]
Message-ID: <52DBCDFE.3080005@dev.mellanox.co.il> (raw)
In-Reply-To: <1390127858-9806-1-git-send-email-sagig@mellanox.com>
On 1/19/2014 12:37 PM, Sagi Grimberg wrote:
> Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries.
>
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/qp.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index 7981620..58c4735 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -1952,9 +1952,9 @@ static int format_selector(struct ib_sig_attrs *attr,
> {
>
> #define FORMAT_DIF_NONE 0
> -#define FORMAT_DIF_CRC_INC 4
> -#define FORMAT_DIF_CSUM_INC 12
> -#define FORMAT_DIF_CRC_NO_INC 13
> +#define FORMAT_DIF_CRC_INC 8
> +#define FORMAT_DIF_CRC_NO_INC 12
> +#define FORMAT_DIF_CSUM_INC 13
> #define FORMAT_DIF_CSUM_NO_INC 14
>
> switch (domain->sig.dif.type) {
Just a clarification,
This patch along with "Fix smatch warnings" are incremental patches to
v4 of pending Signature verbs patchset.
Sagi.
prev parent reply other threads:[~2014-01-19 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 10:37 [PATCH] IB/mlx5: Fix signature rule constants according to FW specifications Sagi Grimberg
2014-01-19 13:07 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DBCDFE.3080005@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox