public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH for-next] IB/mlx4: Add dependency INET
Date: Mon, 20 Jan 2014 00:32:46 +0200	[thread overview]
Message-ID: <52DC528E.2040404@mellanox.com> (raw)
In-Reply-To: <1389885408-21897-2-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

On 16/01/2014 17:16, Matan Barak wrote:
> Since mlx4_ib supports IP based addressing, a dependency on
> INET should be added. This is mandatory since mlx4_ib
> registers itself to net device events.
>
> Signed-off-by: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> Hi Roland,
>
> The mlx4_ib driver registers itself to network events.
> This is mandatory for adding IP based GIDs.
> Thus, we need to introduce a new dependency on INET.

Roland, I see that you've picked this patch, thanks. Note the same patch 
need to be done for ocrdma, since
it also registered to the notifiers under the IP addressing patches.

Or.




>
> Thanks,
> Matan
>
>   drivers/infiniband/hw/mlx4/Kconfig |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/Kconfig b/drivers/infiniband/hw/mlx4/Kconfig
> index 24ab11a..fc01dea 100644
> --- a/drivers/infiniband/hw/mlx4/Kconfig
> +++ b/drivers/infiniband/hw/mlx4/Kconfig
> @@ -1,6 +1,6 @@
>   config MLX4_INFINIBAND
>   	tristate "Mellanox ConnectX HCA support"
> -	depends on NETDEVICES && ETHERNET && PCI
> +	depends on NETDEVICES && ETHERNET && PCI && INET
>   	select NET_VENDOR_MELLANOX
>   	select MLX4_CORE
>   	---help---

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2014-01-19 22:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 15:16 [PATCH for-next] IB/core: Add a dependency of ib_core in ib_addr Matan Barak
     [not found] ` <1389885408-21897-1-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-01-16 15:16   ` [PATCH for-next] IB/mlx4: Add dependency INET Matan Barak
     [not found]     ` <1389885408-21897-2-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-01-19 22:32       ` Or Gerlitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DC528E.2040404@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox