From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
Cc: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH for-next V1 1/2] IB/core: Fix build warnings
Date: Thu, 23 Jan 2014 14:29:06 +0200 [thread overview]
Message-ID: <52E10B12.2080504@mellanox.com> (raw)
In-Reply-To: <1390470420.9865.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On 23/01/2014 11:47, Yann Droneaud wrote:
> Hi,
>
> Le dimanche 03 novembre 2013 à 10:20 +0200, Or Gerlitz a écrit :
>> >Fix the below few "make W=1" build warnings we have on the IB core.
>> >
>> >drivers/infiniband/core/sysfs.c: In function ‘state_show’:
>> >drivers/infiniband/core/sysfs.c:107: warning: comparison of unsigned expression >= 0 is always true
>> >drivers/infiniband/core/verbs.c: In function ‘ib_modify_qp_is_ok’:
>> >drivers/infiniband/core/verbs.c:783: warning: comparison of unsigned expression < 0 is always false
>> >drivers/infiniband/core/verbs.c:784: warning: comparison of unsigned expression < 0 is always false
>> >drivers/infiniband/core/iwcm.c: In function ‘destroy_cm_id’:
>> >drivers/infiniband/core/iwcm.c:330: warning: variable ‘ret’ set but not used
>> >
>> >Signed-off-by: Or Gerlitz<ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Yann Droneaud<ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
>
> PS: Perhaps you could split the patch in two parts: one to remove the
> unused variable, and another to remove the check on unsigned variables ?
Roland decided not to take the unsigned expression < 0 patches, writing
to me
"I applied the unused variable fix, but the others seem not needed,
because the latest kernel seems to include -Wno-sign-compare."
what's your thinking?
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-23 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-03 8:20 [PATCH for-next V1 0/2] Fix build warnings in the IB core and mlx4_ib Or Gerlitz
[not found] ` <1383466844-8805-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-11-03 8:20 ` [PATCH for-next V1 1/2] IB/core: Fix build warnings Or Gerlitz
[not found] ` <1383466844-8805-2-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-01-23 9:47 ` Yann Droneaud
[not found] ` <1390470420.9865.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-01-23 12:29 ` Or Gerlitz [this message]
[not found] ` <52E10B12.2080504-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-01-23 15:15 ` Yann Droneaud
2013-11-03 8:20 ` [PATCH for-next V1 2/2] IB/mlx4: " Or Gerlitz
2014-01-22 22:19 ` [PATCH for-next V1 0/2] Fix build warnings in the IB core and mlx4_ib Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E10B12.2080504@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox