From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Upinder Malhi (umalhi)"
<umalhi-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Faisal Latif
<faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Mike Marciniszyn
<infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hoang-Nam Nguyen
<hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
Steve Wise <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
Shachar Raindel <raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] IB: Refactor umem to use linear SG table
Date: Tue, 28 Jan 2014 15:01:22 +0200 [thread overview]
Message-ID: <52E7AA22.8020700@mellanox.com> (raw)
In-Reply-To: <1390909215-5331-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On 28/01/2014 13:40, Or Gerlitz wrote:
> From: Yishai Hadas<yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> This patch does refactoring of the IB core umem code and vendor drivers to use
> linear SG table instead of chunk list. With this change the relevant code becomes
> more clear, no need for nested loops to build and use umem.
>
> The patch includes: umem changes to work with linear SG table and Vendors driver
> changes to use SG instead of chunk list.
>
> Cc: Faisal Latif<faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Mike Marciniszyn<infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Hoang-Nam Nguyen<hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
> Cc: Steve Wise<swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Shachar Raindel<raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Yishai Hadas<yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> drivers/infiniband/core/umem.c | 120 ++++++-------
> drivers/infiniband/hw/amso1100/c2_provider.c | 23 +--
> drivers/infiniband/hw/cxgb3/iwch_provider.c | 19 +--
> drivers/infiniband/hw/cxgb4/mem.c | 39 ++---
> drivers/infiniband/hw/ehca/ehca_classes.h | 2 +-
> drivers/infiniband/hw/ehca/ehca_mrmw.c | 245 ++++++++++---------------
> drivers/infiniband/hw/ipath/ipath_mr.c | 39 ++---
> drivers/infiniband/hw/mlx4/doorbell.c | 4 +-
> drivers/infiniband/hw/mlx4/mr.c | 39 ++--
> drivers/infiniband/hw/mlx5/doorbell.c | 4 +-
> drivers/infiniband/hw/mlx5/mem.c | 80 ++++----
> drivers/infiniband/hw/mthca/mthca_provider.c | 42 ++---
> drivers/infiniband/hw/nes/nes_verbs.c | 253 +++++++++++++-------------
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 66 ++++----
> drivers/infiniband/hw/qib/qib_mr.c | 14 +-
> include/rdma/ib_umem.h | 11 +-
> 16 files changed, 448 insertions(+), 552 deletions(-)
While looking on this patch I suddenly noticed that unlike the rest of
the hw drivers, the usnic driver doesn't call ib_umem_get but rather
implements it -- while duplicating code/functionality which exists in
the IB core, agree? why?
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-28 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 11:40 [PATCH] IB: Refactor umem to use linear SG table Or Gerlitz
[not found] ` <1390909215-5331-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-01-28 13:01 ` Or Gerlitz [this message]
[not found] ` <52E7AA22.8020700-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-02-01 1:45 ` Upinder Malhi (umalhi)
[not found] ` <1F4FC384-349B-4F37-B06E-214A0B8570DE-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2014-02-03 7:30 ` Shachar Raindel
[not found] ` <6B2A6E60C06CCC42AE31809BF572352B8CF3AC3B-LSMZvP3E4uyuSA5JZHE7gA@public.gmane.org>
2014-02-03 18:38 ` Or Gerlitz
2014-02-04 1:30 ` Upinder Malhi (umalhi)
2014-02-05 18:57 ` Upinder Malhi (umalhi)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E7AA22.8020700@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
--cc=umalhi-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox