From: Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
To: Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Nicholas A. Bellinger"
<nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>,
"linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mike Christie <MChristie-5c4llco8/ftWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports
Date: Mon, 17 Mar 2014 11:59:09 -0500 [thread overview]
Message-ID: <532729DD.1040506@cs.wisc.edu> (raw)
In-Reply-To: <CAJZOPZ+DtO7AqMgFJqm7uz2zwxk5Gs__J10qHhwB0RbAxzYTkQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 03/17/2014 02:25 AM, Or Gerlitz wrote:
> On Wed, Mar 5, 2014 at 7:43 PM, Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
>> >
>> > iSCSI needs to be at least aware that a task involves protection
>> > information. In case it does, after the transaction completed
>> > libiscsi will ask the transport to check the protection status
>> > of the transaction.
>> >
>> > Unlike transport errors, DIF errors should not prevent successful
>> > completion of the transaction from the transport point of view,
>> > but should be escelated to scsi mid-layer when constructing the
>> > scsi result and sense data.
>> >
>> > check_protection routine will return the ascq corresponding to the
>> > DIF error that occured (or 0 if no error happened).
>> >
>> > return ascq:
>> > - 0x1: GUARD_CHECK_FAILED
>> > - 0x2: APPTAG_CHECK_FAILED
>> > - 0x3: REFTAG_CHECK_FAILED
> Hi Mike, just to remove doubt, this patch is OK with you, right? can
> you please ack it, so we know we're all good for the 3.15 merge window
>
This patch is ok, but happened to the patch for the xmit task path?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-17 16:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 17:43 [PATCH v2 00/13] T10-PI support for iSER initiator Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 03/13] IB/iser: Move fast_reg_descriptor initialization to a function Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 04/13] IB/iser: Keep IB device attributes under iser_device Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 06/13] IB/iser: Generalize iser_unmap_task_data and finalize_rdma_unaligned_sg Sagi Grimberg
[not found] ` <1394041431-28399-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-03-05 17:43 ` [PATCH v2 01/13] IB/iser: Avoid FRWR notation, use fastreg instead Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 02/13] IB/iser: Push the decision what memory key to use into fast_reg_mr routine Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 05/13] IB/iser: Replace fastreg descriptor valid bool with indicators container Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 07/13] IB/iser: Generalize fall_to_bounce_buf routine Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 08/13] IB/iser: Introduce pi_enable, pi_guard module parameters Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 09/13] IB/iser: Initialize T10-PI resources Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 13/13] IB/iser: Publish T10-PI support to SCSI midlayer Sagi Grimberg
2014-03-10 19:08 ` [PATCH v2 00/13] T10-PI support for iSER initiator Or Gerlitz
2014-03-05 17:43 ` [PATCH v2 10/13] IB/iser: Support T10-PI operations Sagi Grimberg
2014-03-05 17:43 ` [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports Sagi Grimberg
[not found] ` <1394041431-28399-12-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-03-17 7:25 ` Or Gerlitz
[not found] ` <CAJZOPZ+DtO7AqMgFJqm7uz2zwxk5Gs__J10qHhwB0RbAxzYTkQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-17 16:59 ` Mike Christie [this message]
[not found] ` <532729DD.1040506-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2014-03-17 20:34 ` Sagi Grimberg
[not found] ` <53275C4F.1040103-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-03-17 21:46 ` Or Gerlitz
2014-03-05 17:43 ` [PATCH v2 12/13] IB/iser: Implement check_protection Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532729DD.1040506@cs.wisc.edu \
--to=michaelc-hcno3ddehluvc3sceru5cw@public.gmane.org \
--cc=MChristie-5c4llco8/ftWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \
--cc=or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox