Re: [PATCH] libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down

[Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 4/15/2014 12:43 PM, Ira Weiny wrote:
> Ammar,
> 
> This patch does not apply cleanly.
> 
> 09:41:21 > git am ../\[PATCH\]__libibmad_src_dump.c___Set_the_vlaue_of__LinkWidthActive_to_undefined\(width\)_when_the_port_is_down.eml 
> Applying: libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down
> fatal: patch fragment without header at line 18: @@ -171,6 +171,9 @@ void mad_dump_linkwidth(char *buf, int bufsz, void *val,
> Patch failed at 0001 libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down
> 
> 
> Also I don't think it showed up on linux-rdma.
> 
> Could you make sure to send as plain text.  That could be why linux-rdma dropped it and I missed it.
> 
> Thanks,
> Ira
> 
> 
> On Mon, 17 Mar 2014 15:10:10 +0200
> Ammar Haj Hamad <ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org> wrote:
> 
>> This patch is to set the vlaue of LinkWidthActive to undefined({width}) when
>> the port is down
>>
>>  
>>
>> Signed-off-by: Ammar Haj Hamad <ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org>
>>
>> ---
>>
>> src/dump.c |    3 +++
>>
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>>  
>>
>> diff --git a/src/dump.c b/src/dump.c
>>
>> index f77d739..4bc8153 100644
>>
>> --- a/src/dump.c
>>
>> +++ b/src/dump.c
>>
>> @@ -171,6 +171,9 @@ void mad_dump_linkwidth(char *buf, int bufsz, void *val,
>> int valsz)
>>
>>                int width = *(int *)val;
>>
>>                 switch (width) {
>>
>> +             case 0: 
>>
>> +                             snprintf(buf , bufsz , "undefined (%d)",
>> width);
>>
>> +                             break;

Why special case width 0 and not handle this in default case as is
currently done in mad_dump_linkspeed ?

-- Hal

>>
>>                case 1:
>>
>>                                snprintf(buf, bufsz, "1X");
>>
>>                                break;
>>
>> -- 
>>
>> 1.7.1
>>
>>  
>>
>>  
>>
>>  
>>
>>  
>>
>>   _____  
>>
>> Ammar Omar Haj Hamad |    Software Engineer           |   ASAL technologies
>> - Mellanox
>>
>> Mobile : +970599751673  |    ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org   | Skype :
>> ammar.hajhamad.asal
>>
>>  
>>
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html