* [PATCH libibmad] dump.c: In mad_dump_linkwidth, output undefined widths
@ 2014-04-15 17:35 Hal Rosenstock
[not found] ` <534D6DE1.4010306-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Hal Rosenstock @ 2014-04-15 17:35 UTC (permalink / raw)
To: Ira Weiny
Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
Ammar Haj Hamad, rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Based on patch for this for width 0 from Ammar Haj Hamad <ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org>
Some implementations when port is down appear to return a link width of 0
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/dump.c b/src/dump.c
index 7f3ef7d..efe4bc4 100644
--- a/src/dump.c
+++ b/src/dump.c
@@ -185,7 +185,8 @@ void mad_dump_linkwidth(char *buf, int bufsz, void *val, int valsz)
break;
default:
IBWARN("bad width %d", width);
- buf[0] = 0;
+ snprintf(buf, bufsz, "undefined (%d)", width);
+ break;
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH libibmad] dump.c: In mad_dump_linkwidth, output undefined widths
[not found] ` <534D6DE1.4010306-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2014-04-19 22:30 ` Weiny, Ira
0 siblings, 0 replies; 2+ messages in thread
From: Weiny, Ira @ 2014-04-19 22:30 UTC (permalink / raw)
To: Hal Rosenstock
Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
Ammar Haj Hamad, rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
>
>
> Based on patch for this for width 0 from Ammar Haj Hamad
> <ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org>
>
> Some implementations when port is down appear to return a link width of 0
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks applied,
Ira
> ---
> diff --git a/src/dump.c b/src/dump.c
> index 7f3ef7d..efe4bc4 100644
> --- a/src/dump.c
> +++ b/src/dump.c
> @@ -185,7 +185,8 @@ void mad_dump_linkwidth(char *buf, int bufsz, void
> *val, int valsz)
> break;
> default:
> IBWARN("bad width %d", width);
> - buf[0] = 0;
> + snprintf(buf, bufsz, "undefined (%d)", width);
> + break;
> }
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-19 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-15 17:35 [PATCH libibmad] dump.c: In mad_dump_linkwidth, output undefined widths Hal Rosenstock
[not found] ` <534D6DE1.4010306-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-04-19 22:30 ` Weiny, Ira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox